BetterErrors / better_errors

Better error page for Rack apps
MIT License
6.88k stars 437 forks source link

Use SASS to build CSS #498

Closed RobinDaugherty closed 3 years ago

RobinDaugherty commented 3 years ago

This should allow more productivity when developing CSS changes. In development, the scss is compiled without compression and including line comments to help with development.

By moving the block of CSS out of main.erb, the file is reduced by a substantial amount, which should make development a bit easier as well.

When the gem is built (in CI), main.css is built with the compressed CSS and included in the gem. The scss files are not included in the gem.

coveralls commented 3 years ago

Pull Request Test Coverage Report for Build 418192634


Changes Missing Coverage Covered Lines Changed/Added Lines %
lib/better_errors/error_page_style.rb 13 14 92.86%
<!-- Total: 14 15 93.33% -->
Totals Coverage Status
Change from base Build 417949787: -1.5%
Covered Lines: 523
Relevant Lines: 548

💛 - Coveralls