Switch to Rouge for syntax highlighting and add dark syntax-highlighting theme

BetterErrors / better_errors

Better error page for Rack apps

MIT License

6.88k stars 435 forks source link

Switch to Rouge for syntax highlighting and add dark syntax-highlighting theme #500

Closed RobinDaugherty closed 3 years ago

RobinDaugherty commented 3 years ago

Rouge seems to be more actively developed, and most importantly its CSS class names are compatible with Pygments, which means there are more up-to-date themes available for it.

I found a good source (a gist) for Solarized themes that included the Pygments variables, and I built them as SCSS using variables. In order to support dark theme when enabled by the user's (browser) preferences, the dark theme has to override the light theme's directives.

Screen Shot 2020-12-14 at 3 52 23 PM

coveralls commented 3 years ago

Pull Request Test Coverage Report for Build 423536419

0 of 20 (100.0%) changed or added relevant lines in 3 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.8%) to 96.0%

Totals
Change from base Build 419007021:	-0.8%
Covered Lines:	528
Relevant Lines:	550

💛 - Coveralls

coveralls commented 3 years ago

Pull Request Test Coverage Report for Build 423536419

20 of 20 (100.0%) changed or added relevant lines in 3 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.01%) to 96.811%

Totals
Change from base Build 419007021:	0.01%
Covered Lines:	516
Relevant Lines:	533