search

BetterNCM / BGEnhanced

修改网易云背景
GNU General Public License v3.0
21 stars 5 forks source link

feat: add an option to provide better blur effect #16

Closed FlysoftBeta closed 1 year ago

std-microblock commented 1 year ago

Also, reference #14

FlysoftBeta commented 1 year ago

It shouldn't be a feature in the main background effect config as the masked background already had a mask layer. It should be a feature of masked background.

The main difference between filter: blur and backdrop-filter: blur is the first one is using kDecal as tile mode and the second one is using kMirror iirc. kMirror would repeat the shader vertically and horizontally which is ~4x slower under my subjective inference which is of great concern when using videoes as the backdrop. It shouldn't be the default option. The recommended operation is to enlarge the scale so that the edge won't be seen.

Thanks for your clarification. I think this should become a feature instead of a bug fix.

std-microblock commented 1 year ago

It shouldn't be a feature in the main background effect config as the masked background already had a mask layer. It should be a feature of masked background.

FlysoftBeta commented 1 year ago

It shouldn't be a feature in the main background effect config as the masked background already had a mask layer. It should be a feature of masked background.

However, there isn't any blur options in masked background. I think putting this option to the main options is better rather than making it a feature of masked background. If we put it in masked background, we will have duplicate options to set blurry background, which will make the users confused.