BetterSEQTA / BetterSEQTA-Plus

BetterSEQTA+ - A continuation of development of the BetterSEQTA chrome extension.
https://chromewebstore.google.com/detail/betterseqta+/afdgaoaclhkhemfkkkonemoapeinchel
MIT License
19 stars 7 forks source link

sweep: auto disable the animated bckground whenever a custom image or video background is selected. #21

Closed SethBurkart123 closed 10 months ago

SethBurkart123 commented 10 months ago

This will be in the interface subproject, that it needs to be implemented.

Checklist - [ ] ``interface/src/components/BackgroundSelector.tsx`` ![21_flowchart.svg](http://24.199.78.105:8082/public/5095cfb9cba003e76fa8373c7026e3319959e8d98b2fc323d7d794dd25f20b4b_21_flowchart.svg)
sweep-ai[bot] commented 10 months ago
Sweeping

50%

Actions (click)

Sandbox Execution X

Here are the sandbox execution logs prior to making any changes:

Sandbox logs for e0d8997
trunk init 1/3 ✓
⡿ Downloading Trunk 1.17.2...
⡿ Downloading Trunk 1.17.2...
⢿ Downloading Trunk 1.17.2...
⣻ Downloading Trunk 1.17.2...
⣽ Downloading Trunk 1.17.2...
⣾ Downloading Trunk 1.17.2...
⣷ Downloading Trunk 1.17.2...
⣯ Downloading Trunk 1.17.2...
⣟ Downloading Trunk 1.17.2...
⡿ Downloading Trunk 1.17.2...
⢿ Downloading Trunk 1.17.2...
⣻ Downloading Trunk 1.17.2...
⣽ Downloading Trunk 1.17.2...
✔ Downloading Trunk 1.17.2... done
⡿ Verifying Trunk sha256...
✔ Verifying Trunk sha256... done
⡿ Unpacking Trunk...
✔ Unpacking Trunk... done

✔ 12 linters were enabled (.trunk/trunk.yaml)
  checkov 3.0.34 (13 json, 1 yaml file)
  eslint 8.53.0 (26 javascript, 34 typescript files)
  git-diff-check (150 files)
  markdownlint 0.37.0 (3 markdown files) (created .markdownlint.yaml)
  oxipng 9.0.0 (25 png files)
  prettier 3.1.0 (14 css, 4 html, 26 javascript, 13 json, 3 markdown, 1 prettier_supported_configs, 34 typescript, 1 yaml file)
  shellcheck 0.9.0 (1 shell file) (created .shellcheckrc)
  shfmt 3.6.0 (1 shell file)
  svgo 3.0.3 (1 svg file) (created svgo.config.js)
  trivy 0.47.0 (1 yaml file)
  trufflehog 3.62.1 (150 files)
  yamllint 1.33.0 (1 yaml file) (created .yamllint.yaml)
Next Steps
 1. Read documentation
    Our documentation can be found at https://docs.trunk.io
 2. Get help and give feedback
    Join the Trunk community at https://slack.trunk.io
trunk fmt interface/src/components/BackgroundSelector.tsx || exit 0 2/3 ✓
 ✔ Formatted interface/src/components/BackgroundSelector.tsx
Re-checking autofixed files...

Checked 1 file
✔ No issues
trunk check --fix --print-failures interface/src/components/BackgroundSelector.tsx 3/3 ❌ (`1`)
  FAILURES  
 eslint  interface/src/components/BackgroundSelector.tsx  .trunk/out/hTwZZ.yaml
 eslint  interface/src/components/BackgroundSelector.tsx  .trunk/out/ekAOE.yaml
  NOTICES  
 [suggestion] Eslint could not resolve dependencies; try running `npm install`, `yarn install`, or your equivalent      
 thereof                                                                                                                
 Some tools failed to run. You can open the details yaml files for more information.                                    
Checked 1 file
✖ No issues, 2 failures
# .trunk/out/hTwZZ.yaml
trunk_cli_version: 1.17.2
title: eslint exited with exit_code=2
report:
  - eslint exited with exit_code=2
  - suggestion: Eslint could not resolve dependencies; try running `npm install`, `yarn install`, or your equivalent thereof
  - linter:
      command: |
        /root/.cache/trunk/tools/eslint/8.53.0-588492ac935bedaae36aaee0518fd6d8/node_modules/.bin/eslint --output-file /tmp/trunk-0/pMtm2m/6eceSdvNfFmK --format json interface/src/components/BackgroundSelector.tsx
      stdin_path: (none)
      run_from: /tmp/trunk-0/L8lL6j/IwfqK6
      timeout: 10m
      rerun: (cd /tmp/trunk-0/L8lL6j/IwfqK6; env -i PATH=/root/.cache/trunk/tools/eslint/8.53.0-588492ac935bedaae36aaee0518fd6d8/node_modules/.bin:/root/.cache/trunk/tools/node/18.12.1-00ae74f39ac4de3ff3c7e3686016ebf3/bin:/root/.cache/trunk/tools/node/18.12.1-00ae74f39ac4de3ff3c7e3686016ebf3:/root/.nvm/versions/node/v18.17.0/bin/:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin HOME=/root NODE_PATH=/root/.cache/trunk/tools/eslint/8.53.0-588492ac935bedaae36aaee0518fd6d8/node_modules /root/.cache/trunk/tools/eslint/8.53.0-588492ac935bedaae36aaee0518fd6d8/node_modules/.bin/eslint --output-file /tmp/trunk-0/pMtm2m/6eceSdvNfFmK --format json interface/src/components/BackgroundSelector.tsx)
      affects_cache:
        - package.json
        - tsconfig.json
      direct_configs:
        - .eslintrc.json
      exit_status: exited
      exit_code: 2
      stdout: (none)
      stderr: |
        Oops! Something went wrong! :(
        ESLint: 8.53.0
        ESLint couldn't find the plugin "@typescript-eslint/eslint-plugin".
        (The package "@typescript-eslint/eslint-plugin" was not found when loaded as a Node module from the directory "/tmp/trunk-0/L8lL6j/IwfqK6/interface".)
        It's likely that the plugin isn't installed correctly. Try reinstalling by running the following:
            npm install @typescript-eslint/eslint-plugin@latest --save-dev
        The plugin "@typescript-eslint/eslint-plugin" was referenced from the config file in "interface/.eslintrc.cjs".
        If you still can't figure out the problem, please stop by https://eslint.org/chat/help to chat with the team.
    parser: |
      (none)
# .trunk/out/ekAOE.yaml
trunk_cli_version: 1.17.2
title: eslint exited with exit_code=2
report:
  - eslint exited with exit_code=2
  - suggestion: Eslint could not resolve dependencies; try running `npm install`, `yarn install`, or your equivalent thereof
  - linter:
      command: |
        /root/.cache/trunk/tools/eslint/8.53.0-588492ac935bedaae36aaee0518fd6d8/node_modules/.bin/eslint --output-file /tmp/trunk-0/XENa5w/toUcmGLWnVRS --format json interface/src/components/BackgroundSelector.tsx
      stdin_path: (none)
      run_from: /tmp/trunk-0/Vpn3uR/CKg6jU
      timeout: 10m
      rerun: (cd /tmp/trunk-0/Vpn3uR/CKg6jU; env -i PATH=/root/.cache/trunk/tools/eslint/8.53.0-588492ac935bedaae36aaee0518fd6d8/node_modules/.bin:/root/.cache/trunk/tools/node/18.12.1-00ae74f39ac4de3ff3c7e3686016ebf3/bin:/root/.cache/trunk/tools/node/18.12.1-00ae74f39ac4de3ff3c7e3686016ebf3:/root/.nvm/versions/node/v18.17.0/bin/:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin HOME=/root NODE_PATH=/root/.cache/trunk/tools/eslint/8.53.0-588492ac935bedaae36aaee0518fd6d8/node_modules /root/.cache/trunk/tools/eslint/8.53.0-588492ac935bedaae36aaee0518fd6d8/node_modules/.bin/eslint --output-file /tmp/trunk-0/XENa5w/toUcmGLWnVRS --format json interface/src/components/BackgroundSelector.tsx)
      affects_cache:
        - package.json
        - tsconfig.json
      direct_configs:
        - .eslintrc.json
      exit_status: exited
      exit_code: 2
      stdout: (none)
      stderr: |
        Oops! Something went wrong! :(
        ESLint: 8.53.0
        ESLint couldn't find the plugin "@typescript-eslint/eslint-plugin".
        (The package "@typescript-eslint/eslint-plugin" was not found when loaded as a Node module from the directory "/tmp/trunk-0/Vpn3uR/CKg6jU/interface".)
        It's likely that the plugin isn't installed correctly. Try reinstalling by running the following:
            npm install @typescript-eslint/eslint-plugin@latest --save-dev
        The plugin "@typescript-eslint/eslint-plugin" was referenced from the config file in "interface/.eslintrc.cjs".
        If you still can't figure out the problem, please stop by https://eslint.org/chat/help to chat with the team.
    parser: |
      (none)

Sandbox failed, so all sandbox checks will be disabled for this issue.


❌ Unable to Complete PR

I'm sorry, but it looks like an error has occurred. Try changing the issue description to re-trigger Sweep. If this error persists report it at https://discord.gg/sweep.

For bonus GPT-4 tickets, please report this bug on Discord (tracking ID: 0e926d2a74).


Please look at the generated plan. If something looks wrong, please add more details to your issue.

File Path Proposed Changes
interface/src/components/BackgroundSelector.tsx Modify interface/src/components/BackgroundSelector.tsx with contents:
• In the selectBackground function, add a call to disableTheme before setting the selected background and saving it to local storage. This will ensure that the animated background is disabled whenever a new background is selected.
• The modified selectBackground function should look like this:
```tsx
const selectBackground = (fileId: string): void => {
disableTheme();
setSelectedType('background');
setSelectedBackground(fileId);
localStorage.setItem('selectedBackground', fileId);
};
```

🎉 Latest improvements to Sweep:


💡 To recreate the pull request edit the issue title or description. To tweak the pull request, leave a comment on the pull request.