search

BetterSEQTA / BetterSEQTA-Plus

BetterSEQTA+ - A continuation of development of the BetterSEQTA chrome extension.
https://chromewebstore.google.com/detail/betterseqta+/afdgaoaclhkhemfkkkonemoapeinchel
MIT License
19 stars 7 forks source link

Use of Unicode icons within CSS creates undefined behaviour and general weirdness #57

Open Crazypersonalph opened 10 months ago

Crazypersonalph commented 10 months ago

Good afternoon everyone, In my testing of BetterSEQTA+ and in my bugfixing, I have found that the use of unicode icons within the project creates undefined behaviour, that appears sometimes, but disappears other times.

Sometimes, said unicode icons such as the delete icon disappear and are replaced with the unicode icon not found placeholder.

I have found that its occurrence fluctuates, and because of this, I couldn't take a screenshot of it.

I believe the best course of action would be to replace the unicode icons with SVG images, as they have proven to be much more stable

Kind Regards

Crazypersonalph commented 10 months ago

Found examples: image

image

image

SethBurkart123 commented 10 months ago

Absolutely, your suggestion about using SVG images instead of unicode icons in BetterSEQTA+ makes a lot of sense. Originally, I opted for font-based icons primarily for their simplicity in CSS integration. However, this approach does have its drawbacks, particularly when it comes to color customization, which can get quite complex. Although it was a practical solution at the time, I'm open to exploring SVG images, given their stability and consistency.

SethBurkart123 commented 10 months ago

I am currently using a closed source icon library, I can add all of the svg's to the project if you'd like. You can play around with a bit of an implementation.

Crazypersonalph commented 10 months ago

I am currently using a closed source icon library, I can add all of the svg's to the project if you'd like. You can play around with a bit of an implementation.

Is it FontAwesome?

SethBurkart123 commented 10 months ago

I am currently using a closed source icon library, I can add all of the svg's to the project if you'd like. You can play around with a bit of an implementation.

Is it FontAwesome?

No, it is https://www.untitledui.com/icons I have the full version along with all of the icons in SVG format.

SethBurkart123 commented 7 months ago

But the question is @Crazypersonalph,

Is it worth replacing with javascript? Or do we want to be limited by using a background-image. Before now it wasn't reasonable, but I modified dark mode to instead place a class .dark on the main html element, so it might be feasible as long as we aren't doing anything too crazy with the text colours?

The main reason for going with an icon font originally was pretty much so that the icons would follow the currentColor of the elements without requiring any javascript.

ar-cyber commented 3 months ago

Has this been patched? I cannot recreate it.

SethBurkart123 commented 3 months ago

It's still there, but only occasionally shows up- that's what makes it quite difficult.

ar-cyber commented 3 weeks ago

I think this is stale and should be closed as not planned because of the inactivity.

Crazypersonalph commented 3 weeks ago

Will probably keep open since it is still relevant and will probably on the to-do in the future.