search

BetterStackHQ / logs-helm-chart

Send Kubernetes logs and metrics to Better Stack.
https://betterstack.com/logs
MIT License
5 stars 3 forks source link

feat: add a way to disable metrics server #1

Closed MickaelCa closed 8 months ago

MickaelCa commented 9 months ago

Metrics server is already installed on my cluster. This PR allow me to disable its installation via the betterstack logs chart

MickaelCa commented 9 months ago

~working as intended with this update and these values : 

metrics-server:
  enabled: false
vector:
  customConfig:
    sinks:
      better_stack_http_sink:
        auth:
          token: redacted
      better_stack_http_metrics_sink:
        auth:
          token: redacted

    sources:
      better_stack_kubernetes_metrics_nodes:
        endpoint: https://metrics-server.kube-system.svc.cluster.local/apis/metrics.k8s.io/v1beta1/nodes
        tls:
          verify_certificate: false
      better_stack_kubernetes_metrics_pods:
        endpoint: https://metrics-server.kube-system.svc.cluster.local/apis/metrics.k8s.io/v1beta1/pods
        tls:
          verify_certificate: false

Edit : Not really working, vector pods are in a crash loop but I'm not sure if it's linked to my PR.

2023-09-29T01:03:43.610020Z ERROR transform{component_kind="transform" component_id=better_stack_kubernetes_metrics_pods_parser component_type=remap component_name=better_stack_kubernetes_metrics_pods_parser}: vector::internal_events::remap: Mapping failed with event. error="function call error for \"for_each\" at (53:1014): function call error for \"for_each\" at (268:1012): function call error for \"push\" at (397:691): function call error for \"to_float\" at (500:555): Invalid floating point number \"1713u\": invalid float literal" error_type="conversion_failed" stage="processing" internal_log_rate_limit=true
thread 'vector-worker' panicked at 'event will be set', src/transforms/remap.rs:570:48
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
thread 'vector-worker' panicked at 'internal error: entered unreachable code: join error or bad poll', src/topology/builder.rs:886:30
2023-09-29T01:03:43.610875Z ERROR transform{component_kind="transform" component_id=better_stack_kubernetes_metrics_pods_parser component_type=remap component_name=better_stack_kubernetes_metrics_pods_parser}: vector::topology: An error occurred that Vector couldn't handle: the task panicked and was aborted.
2023-09-29T01:03:43.610929Z  INFO vector: Vector has stopped.
speier commented 9 months ago

@JanPokorny could you please merge this PR, this is essential, metrics-server should be optional. 🙏