fancybear-dev
commented
3 weeks ago Based on this issue (https://github.com/BetterStackHQ/terraform-provider-better-uptime/issues/19) and API docs (https://betterstack.com/docs/uptime/api/create-a-new-monitor/#example-curl) I suspect the provider does insufficient validation for the input value of request_headers of the betteruptime_monitor resource. We have a condition in place that results in a null value being passed, which is accepted - but seemingly not processed properly by the provider -> resulting in the conversion panic. Testing this now.
I find the API odd in general as well - never seen a data structure like this for this purpose;
"request_headers": [
{
"name": "X-Custom-Header",
"value": "custom header value"
}
]This is overly complex to simply pass headers, something like;
"request_headers": {
header_key: header_value,
header_key2: header_value2
}makes more sense to me personally - it also reads better in places like Terraform. I'm sure there are reasons for the existing solution, but thought I'd share regardless.
Right now in Terraform I do the conversion like this (to pass it 1:1 to the resource) - but this conversion in itself is the thing I find odd but it's what it is because the API expects it like this;
headers = {
"Authorization" = "whatever"
"magic" = "tree"
}
request_headers = [
for header_key, header_value in local.headers: {
name = header_key
value = header_value
}
]
PetrHeinz
Hi,
We're running into what seems to be a provider bug, but we're unsure as of yet.
Resources it seems to affect;
I have not been able to reproduce it outside of our production environment yet, but also cannot share those details. These kinds of errors can happen in case of a lack of memory, we have not validated this yet. It would be unusual, given we run on a 32GB RAM environment that is very lean. I'm aware this is limited information to do anything with, but wanted to report it regardless and keep you in the loop in case we find a root cause / fix. If this is something that someone else has seen / if this is a known issue - I'd eagerly would want to know.