BetterStackHQ / terraform-provider-better-uptime

Apache License 2.0
46 stars 14 forks source link

betteruptime_monitor: variable verify_ssl = false should disable ssl_expiration variable #44

Closed Edeholland closed 10 months ago

Edeholland commented 1 year ago

When you have a betteruptime_monitor with verify_ssl = false and without setting the ssl_expiration variable, you get an error:

Error: PATCH https://betteruptime.com/api/v2/monitors/xxxxxxx returned 422: {"errors":{"base":["SSL expiration is invalid. Valid values are: [nil, 1, 2, 3, 7, 14, 30, 60]"]}}

Using verify_ssl = false should disable the need for the ssl_expiration variable. This can be done in more ways than one:

Tatarkow commented 11 months ago

Hello,

William from Better Stack here. I apologise once again for the troubles.

After checking the issue it seems that it is now possible to both create resources with verify_ssl = false and modify verify_ssl of existing resources to false. That said, I noticed a warning message regarding null values (including ssl_expiration) and legacy Terraform SDK. image

Tatarkow commented 10 months ago

Following my previous message, it looks like the issue has been resolved.