BetterThanTomorrow / calva

Clojure & ClojureScript Interactive Programming for VS Code
https://marketplace.visualstudio.com/items?itemName=betterthantomorrow.calva
Other
1.67k stars 217 forks source link

Reload clojure-lsp settings without reloading the vscode window #1113

Open sauvala opened 3 years ago

sauvala commented 3 years ago

Changing the clojure-lsp settings in ./lsp/config.edn requires reloading the vscode window. It would be cool if there would a way to reload clojure-lsp without reloading vscode.

ericdallo commented 3 years ago

we could make clojure-lsp always read again from .lsp/config.edn, not sure if this would affect performance as we check settings all the time for multiple features, as the last resource maybe use a small cache of some seconds?

Suggestinos @snoe @borkdude?

PEZ commented 3 years ago

I saw some new library flash by somewhere, extracting efficient file watching out of Krell. But my experience from Calva to read the config every time is that it is cheap. Iirc, Calva reads the formatter config on each invocation, which is often.

ericdallo commented 3 years ago

Yeah, but I bet VSCode has some kind of cache for those settings, for clojure-lsp case, we would need to read a file from disk