search

BetterThanTomorrow / calva

Clojure & ClojureScript Interactive Programming for VS Code
https://marketplace.visualstudio.com/items?itemName=betterthantomorrow.calva
Other
1.67k stars 217 forks source link

Clojure-lsp not starting when offline #1299

Open temochka opened 3 years ago

temochka commented 3 years ago

When my Mac is offline (or I’m on a corporate VPN) and I open a Clojure project in VS Code with Calva, the Clojure-lsp server doesn’t start and thus all LSP-powered functionality is unavailable. Calva Diagnostics : Clojure-lsp Server Info says "There is no clojure-lsp server running." The welcome message from Calva looks as usual, there’s no visible indication of an error.

As soon as I re-connect to wi-fi (or disconnect from the corporate VPN) and restart VS Code, Clojure-lsp starts as expected. I was able to reproduce this issue both on my work and personal laptops.

Note: I do realize that by default Calva downloads the latest version of Clojure-lsp, but I always assumed it would re-use the latest available download if offline.

PEZ commented 3 years ago

Hello @temochka. Thanks for the issue report!

We should definitely be able to use whatever clojure-lsp we have downloaded since before.

bpringe commented 3 years ago

Calva uses the last downloaded clojure-lsp binary if the download fails (at least, it is supposed to). Does it seem like there is an issue with this? If so, we should investigate.

If there was no previous download, then there will be no previous binary.

One solution/workaround to using clojure-lsp offline is to download the binary when/where you do have a connection, and make Calva use that downloaded binary: https://calva.io/clojure-lsp/#using-a-custom-clojure-lsp-native-binary.