search

BetterThanTomorrow / calva

Clojure & ClojureScript Interactive Programming for VS Code
https://marketplace.visualstudio.com/items?itemName=betterthantomorrow.calva
Other
1.68k stars 217 forks source link

Pretty printing looks enabled in the status bar when it's not #1351

Open bpringe opened 3 years ago

bpringe commented 3 years ago

This happens after version 2.0.216. If you remove calva.prettyPrintingOptions from your settings and reload the window, the pprint button in the status bar looks as though pretty printing is enabled, but pretty printing does not occur when results are printed.

@PEZ, do we want pretty printing enabled by default or not? Either way, we should make sure the status bar button reflects the correct status of pretty printing enablement.

Related change: https://github.com/BetterThanTomorrow/calva/pull/1342

PEZ commented 3 years ago

I think disabled is a good default. But I am fine with both, as long as the button is not lying. 😀