search

BetterThanTomorrow / calva

Clojure & ClojureScript Interactive Programming for VS Code
https://marketplace.visualstudio.com/items?itemName=betterthantomorrow.calva
Other
1.7k stars 218 forks source link

Jump to definition fails after the destination file has been closed #1458

Closed introom closed 2 years ago

introom commented 2 years ago

How to reproduce this issue: For example,

  1. Clone the repo: https://github.com/dharrigan/startrek
  2. Place cursor on the line https://github.com/dharrigan/startrek/blob/master/src/startrek/api/general/swagger.clj/#L11
  3. Jump to definition for create-swagger-handler
  4. CLOSE the source file containing create-swagger-handler
  5. Go back to step 2, and perform jump to definition. It complains no definition found.
introom commented 2 years ago

cc @ericdallo

ericdallo commented 2 years ago

I confirmed the issue happens only with Calva indeed, @bpringe I think we should prioritize this fix somehow, I already faced and saw people facing it multiple times. I think it's related with calva custom code for opening jars

bpringe commented 2 years ago

This is happening without a connected repl, correct?

younger-1 commented 2 years ago

This is happening without a connected repl, correct?

To me, yes

bpringe commented 2 years ago

https://github.com/BetterThanTomorrow/calva/issues/1494 is a duplicate of this one, but let's close this one and track the issue there, since that issue has some troubleshooting info already.