BetterThanTomorrow / calva

Clojure & ClojureScript Interactive Programming for VS Code
https://marketplace.visualstudio.com/items?itemName=betterthantomorrow.calva
Other
1.63k stars 213 forks source link

Support Problem Matchers #1633

Open riotrah opened 2 years ago

riotrah commented 2 years ago

Problem Matchers allow extensions to inform vscode that during certain Tasks - for example those that clj+calva users might define in their workspaces - the console output is to be scanned for useful "Problems" (eg errors, warnings and info messages for specific locations in code that can be listed in the Problems panel, and traversed with keyboard shortcuts).

I propose that Calva provide such problem matchers.

My main motivation is that I do not get any "static" error analysis (eg incorrect number of args etc) when I write clojure code with calva, but do at least see them at compile time and when specs fail. I wish then that, like in my TS projects, I could just traverse thru the problems/bugs and knock them out one-by-one.

This will also probably coincide with another feature request I am opening shortly, will link when/if I do.

PEZ commented 2 years ago

My main motivation is that I do not get any "static" error analysis (eg incorrect number of args etc) when I write clojure code with calva

That sounds like a misconfiguration. Calva uses clj-kondo (by proxy of clojure-lsp) to provide this.

riotrah commented 2 years ago

I'm certain that is the case for myself. I recall with my clj (not cljs - I have no clue why my recent primary cljs project doesn't report errors) projects I'd see the basic arity compile time errors. Would kondo report spec failures tho?

If not, having the problem matcher catch and mark those would be cool, at least if enabled!