LouDnl commented 1 year ago

Calva v2.0.333 is not working for me in VSCode Insiders on Windows 11. Extension doesn't start up and eventually fails with below error. lsp doesn't start up either.

Calva v2.0.332 works just fine. Error thrown in devtools is:


ERR [Extension Host] Error: [UriError]: Scheme contains illegal characters.
    at P (d:\Beheer\_portable-tools\programming\VSCode-win32-x64-1.76.0-insider\resources\app\out\vs\workbench\api\node\extensionHostProcess.js:66:23479)
    at new C (d:\Beheer\_portable-tools\programming\VSCode-win32-x64-1.76.0-insider\resources\app\out\vs\workbench\api\node\extensionHostProcess.js:66:24679)
    at new f (d:\Beheer\_portable-tools\programming\VSCode-win32-x64-1.76.0-insider\resources\app\out\vs\workbench\api\node\extensionHostProcess.js:66:26060)
    at C.parse (d:\Beheer\_portable-tools\programming\VSCode-win32-x64-1.76.0-insider\resources\app\out\vs\workbench\api\node\extensionHostProcess.js:66:25171)
    at c:\Users\thier\.vscode-insiders\extensions\betterthantomorrow.calva-2.0.333\out\extension.js:2:537229
    at Array.map (<anonymous>)
    at c:\Users\thier\.vscode-insiders\extensions\betterthantomorrow.calva-2.0.333\out\extension.js:2:537134
    at Generator.next (<anonymous>)
    at i (c:\Users\thier\.vscode-insiders\extensions\betterthantomorrow.calva-2.0.333\out\extension.js:2:536044)
console.ts:137 [Extension Host] Error: [UriError]: Scheme contains illegal characters.
    at P (d:\Beheer\_portable-tools\programming\VSCode-win32-x64-1.76.0-insider\resources\app\out\vs\workbench\api\node\extensionHostProcess.js:66:23479)
    at new C (d:\Beheer\_portable-tools\programming\VSCode-win32-x64-1.76.0-insider\resources\app\out\vs\workbench\api\node\extensionHostProcess.js:66:24679)
    at new f (d:\Beheer\_portable-tools\programming\VSCode-win32-x64-1.76.0-insider\resources\app\out\vs\workbench\api\node\extensionHostProcess.js:66:26060)
    at C.parse (d:\Beheer\_portable-tools\programming\VSCode-win32-x64-1.76.0-insider\resources\app\out\vs\workbench\api\node\extensionHostProcess.js:66:25171)
    at c:\Users\thier\.vscode-insiders\extensions\betterthantomorrow.calva-2.0.333\out\extension.js:2:537229
    at Array.map (<anonymous>)
    at c:\Users\thier\.vscode-insiders\extensions\betterthantomorrow.calva-2.0.333\out\extension.js:2:537134
    at Generator.next (<anonymous>)
    at i (c:\Users\thier\.vscode-insiders\extensions\betterthantomorrow.calva-2.0.333\out\extension.js:2:536044) (at console.<anonymous> (d:\Beheer\_portable-tools\programming\VSCode-win32-x64-1.76.0-insider\resources\app\out\vs\workbench\api\node\extensionHostProcess.js:96:138847))
T   @   console.ts:137
$logExtensionHostMessage    @   mainThreadConsole.ts:39
N   @   rpcProtocol.ts:455
M   @   rpcProtocol.ts:440
H   @   rpcProtocol.ts:370
G   @   rpcProtocol.ts:296
(anonymous) @   rpcProtocol.ts:161
invoke  @   event.ts:718
deliver @   event.ts:926
fire    @   event.ts:887
fire    @   ipc.net.ts:671
ne.onmessage    @   localProcessExtensionHost.ts:615```

etlinre commented 1 year ago

Calva - update to v2.0.333, unable to start REPL on previously working clojure projects

As per request on #calva slack channel, adding details here also:

similar/same issue with calva v2.0.333 to above (but on windows 10 in my case - environment info at bottom):
(as per slack request), although this happened on all my clojure projects, one example project on which this issue was encountered can be cloned from github: https://github.com/magnars/parens-of-the-dead-s2.git
Full details below.

Symptoms/change:

Change

Took offered "update to latest" on Calva extension, from within VScode, i.e. offered automated update from: v2.0.332 to: v2.0.333

Accepted "restart VS code" option.

Update seemed to succeed as far as VScode concerned.

Fault/result - unable to use REPL or see documentation

errant behaviour when clicking greyed out "REPL" (VScode bottom ribbon) to connect repl,
- never successfully connected to repl
- sometimes offered usual options (leiningen, figwheel, etc),
- sometimes seems to attempt to start REPL without asking for these
- never offered normal option when clicking on REPL (VScode bottom ribbon) to disconnect from the repl
same options from the VScode command menu also did not work

Further info/indicators

The problem was encountered on both leiningen and deps.edn projects, all of which had no problems with REPL yesterday.

"clojure-lsp" spinning wheel when in clojure project (VScode bottom ribbon),
- never changes from spinning wheel status
- left it in this status for several minutes with no change
"activating extension" spinning wheel frequently appears for 1-2 seconds in VScode bottom ribbon, when try to e.g. "Manage Clojure LSP servers"
- hover over to get documentation on clojure functions etc simply provides "Loading...."
it seems to start JVM processes in project folder (checked with jps -m in terminal)

Did not investigate:

I did not investigate

trying to connect to nREPL port with browser
examining processes within JVM (I am not Java experienced)

Attempted fixes

uninstalling and disabling Calva extension from VScode
killing VScode and opening again
killing JVM processes combined with above in different orders
complete restart of PC

Successful fix

Reverting calva extension to v2.0.332

This removed all issues.

Environment information

OS: M/soft windows pro 10, latest, more info with VScode info

VScode info:

Version: 1.75.1 (user setup) Commit: 441438abd1ac652551dbe4d408dfcec8a499b8bf Date: 2023-02-08T21:32:34.589Z Electron: 19.1.9 Chromium: 102.0.5005.194 Node.js: 16.14.2 V8: 10.2.154.23-electron.0 OS: Windows_NT x64 10.0.19045 Sandboxed: No

(clojure-version) "1.10.1"

clementlefevre commented 1 year ago

Indeed, reverting to the v2.0.332 fix the following error :

C:\Users\w131596>cmd.exe /d /c lein update-in :dependencies conj [nrepl,"1.0.0"] -- update-in :plugins conj [cider/cider-nrepl,"0.28.5"] -- update-in [:repl-options,:nrepl-middleware] conj '["cider.nrepl/cider-middleware"]' -- repl :headless
java.lang.NumberFormatException: Invalid number: 1.0.0
 at clojure.lang.LispReader.readNumber (LispReader.java:352)
    clojure.lang.LispReader.read (LispReader.java:278)
    clojure.lang.LispReader.readDelimitedList (LispReader.java:1398)
    clojure.lang.LispReader$VectorReader.invoke (LispReader.java:1347)
    clojure.lang.LispReader.read (LispReader.java:285)
    clojure.lang.LispReader.read (LispReader.java:216)
    clojure.lang.LispReader.read (LispReader.java:205)
    clojure.lang.RT.readString (RT.java:1876)
    clojure.lang.RT.readString (RT.java:1871)
    clojure.core$read_string.invokeStatic (core.clj:3816)
    clojure.core$read_string.invoke (core.clj:3806)
    clojure.core$mapv$fn__8535.invoke (core.clj:6979)
    clojure.core.protocols$fn__8249.invokeStatic (protocols.clj:168)
    clojure.core.protocols/fn (protocols.clj:124)
    clojure.core.protocols$fn__8204$G__8199__8213.invoke (protocols.clj:19)
    clojure.core.protocols$seq_reduce.invokeStatic (protocols.clj:31)
    clojure.core.protocols$fn__8236.invokeStatic (protocols.clj:75)
    clojure.core.protocols/fn (protocols.clj:75)
    clojure.core.protocols$fn__8178$G__8173__8191.invoke (protocols.clj:13)
    clojure.core$reduce.invokeStatic (core.clj:6886)
    clojure.core$mapv.invokeStatic (core.clj:6970)
    clojure.core$mapv.invoke (core.clj:6970)
    leiningen.update_in$parse_args.invokeStatic (update_in.clj:13)
    leiningen.update_in$parse_args.invoke (update_in.clj:9)
    leiningen.update_in$update_in.invokeStatic (update_in.clj:36)
    leiningen.update_in$update_in.doInvoke (update_in.clj:24)
    clojure.lang.RestFn.applyTo (RestFn.java:146)
    clojure.lang.Var.applyTo (Var.java:705)
    clojure.core$apply.invokeStatic (core.clj:669)
    clojure.core$apply.invoke (core.clj:662)
    leiningen.core.main$partial_task$fn__7380.doInvoke (main.clj:284)
    clojure.lang.RestFn.applyTo (RestFn.java:139)
    clojure.lang.AFunction$1.doInvoke (AFunction.java:31)
    clojure.lang.RestFn.applyTo (RestFn.java:137)
    clojure.core$apply.invokeStatic (core.clj:669)
    clojure.core$apply.invoke (core.clj:662)
    leiningen.core.main$apply_task.invokeStatic (main.clj:334)
    leiningen.core.main$apply_task.invoke (main.clj:320)
    leiningen.core.main$resolve_and_apply.invokeStatic (main.clj:343)
    leiningen.core.main$resolve_and_apply.invoke (main.clj:336)
    leiningen.core.main$_main$fn__7469.invoke (main.clj:453)
    leiningen.core.main$_main.invokeStatic (main.clj:442)
    leiningen.core.main$_main.doInvoke (main.clj:439)
    clojure.lang.RestFn.applyTo (RestFn.java:137)
    clojure.lang.Var.applyTo (Var.java:705)
    clojure.core$apply.invokeStatic (core.clj:667)
    clojure.main$main_opt.invokeStatic (main.clj:514)
    clojure.main$main_opt.invoke (main.clj:510)
    clojure.main$main.invokeStatic (main.clj:664)
    clojure.main$main.doInvoke (main.clj:616)
    clojure.lang.RestFn.applyTo (RestFn.java:137)
    clojure.lang.Var.applyTo (Var.java:705)
    clojure.main.main (main.java:40)

with :

C:\Users\user>lein -version
Leiningen 2.10.0 on Java 11.0.18 OpenJDK 64-Bit Server VM

and

Version: 1.75.1 (user setup)
Commit: 441438abd1ac652551dbe4d408dfcec8a499b8bf
Date: 2023-02-08T21:32:34.589Z
Electron: 19.1.9
Chromium: 102.0.5005.194
Node.js: 16.14.2
V8: 10.2.154.23-electron.0
OS: Windows_NT x64 10.0.19044
Sandboxed: No

Btw, Calva is such a cool tool.

PEZ commented 1 year ago

Thanks for the detailed information, folks! We are rolling back the changes for now.

If someone can provide a project where the problem can be reproduced, that would be super helpful! 🙏

etlinre commented 1 year ago

If someone can provide a project where the problem can be reproduced, that would be super helpful! 🙏

@PEZ - as per your request, example project you can clone off of github (its deps.edn, both .cljs and clj, using figwheel) - from github: https://github.com/magnars/parens-of-the-dead-s2.git

[Edit: I should have mentioned, issue was encountered when trying "Fire up the getting started REPL" as well]

(This is not my project but a youtube learning project I happen to be following, they are editing using EMACS/cider so know it is fully working project). (Thanks again for all the work on Calva, its great.)

PEZ commented 1 year ago

Thanks!

[Edit: I should have mentioned, issue was encountered when trying "Fire up the getting started REPL" as well]

From a blank VS Code Window?

etlinre commented 1 year ago

Thanks!

[Edit: I should have mentioned, issue was encountered when trying "Fire up the getting started REPL" as well]

From a blank VS Code Window?

I think I tried it from a project which has no clojure or cljs files (or deps.edn or leiningen) in it - they are all .md or .txt files. But I may have tried it only while in a couple of the various clj/cljs projects I tried to also "normal REPL".... I was skipping around at that stage in a hurry so can't be certain from memory. /thanks

PEZ commented 1 year ago

Deleted your logs from 334 and 332, @LouDnl, since you found out that they were in fact identical. 😄

LouDnl commented 1 year ago

Thanks, I read your pm just before going to bed yesterday 😁 was planning to remove them just now.

BetterThanTomorrow / calva

Calva v2.0.333 has startup and repl issues on Windows #2087

Calva - update to v2.0.333, unable to start REPL on previously working clojure projects

Symptoms/change:

Change

Fault/result - unable to use REPL or see documentation

Further info/indicators

Did not investigate:

Attempted fixes

Successful fix

Environment information

OS: M/soft windows pro 10, latest, more info with VScode info

VScode info:

(clojure-version) "1.10.1"