The command for opening the clojure-lsp log file doesn't (always?) work

BetterThanTomorrow / calva

Clojure & ClojureScript Interactive Programming for VS Code

https://marketplace.visualstudio.com/items?itemName=betterthantomorrow.calva

Other

1.7k stars 218 forks source link

The command for opening the clojure-lsp log file doesn't (always?) work #2269

Open bpringe opened 1 year ago

bpringe commented 1 year ago

It doesn't work for me on MacOS. I think it hasn't worked in a while for me. It seems it should work even if the log path is set dynamically by clojure-lsp since it uses the log path reported from the server's returned info. Either Calva is doing something incorrectly or clojure-lsp isn't returning the right path.

PEZ commented 12 months ago

It could also be that the log file has grown beyond 50Mb and we fail to catch the error from VS Code refusing to open it.

bpringe commented 12 months ago

Hmm... maybe to have a more reliable solution, we should just print the path somewhere for the user and let them open it however they want to.

PEZ commented 12 months ago

Indeed. Command-clicking the path will open it in VS Code, and probably display a proper error message.