search

BetterThanTomorrow / calva

Clojure & ClojureScript Interactive Programming for VS Code
https://marketplace.visualstudio.com/items?itemName=betterthantomorrow.calva
Other
1.61k stars 213 forks source link

error when slurping forward before commented s-expressions #2387

Open blnote opened 7 months ago

blnote commented 7 months ago

Using the slurp sexp forward command at (|) #_(dosomething)

results in

( #_)(dosomething)

and the error:

:uneval node expects 1 value. [at line 1, column 6]

also: drag expression forward in the above scenario produces #_ ()(dosometing) destroying the commented expression. no error is printed in this case.

Calva version used: v2.0.409 clojure-lsp version used: 2023.12.29-12.09.27 clj-kondo version used: 2023.12.15

PEZ commented 6 months ago

Hi! Thanks for reporting!

The issue with how to treat the ignore marker is a bit unsolved in Calva. I agree the behaviour is incorrect, but will have to investigate if it can be easily solved without causing funny behaviour elsewhere.

blnote commented 6 months ago

Hey, thanks for your response! Just wanted to note that slurping ignored forms works with clojure-lsp (using paredit functionality from rewrite-clj i think). however dragging using lsp also has a problem with ignored forms. anyways, certainly not high priority, thanks a lot for your work.

PEZ commented 6 months ago

I see that there is a rather old PR concerning ignore markers and dragging:

I don't recall why we never merged it. Maybe we just forgot? Anyway, I'll have a look and see if it enlightens/reminds me a bit about the nature of the problem.