Use clojure-lsp's feature for auto adding ns forms

BetterThanTomorrow / calva

Clojure & ClojureScript Interactive Programming for VS Code

https://marketplace.visualstudio.com/items?itemName=betterthantomorrow.calva

Other

1.67k stars 217 forks source link

Use clojure-lsp's feature for auto adding ns forms #861

Open bpringe opened 3 years ago

bpringe commented 3 years ago

At this time of writing, clojure-lsp usage is not merged into master, but I'm creating this issue as a reminder for later.

I've set auto-add-ns-to-new-files? in the clojure-lsp's initialization options to false, so that Calva's version of this feature can be used, but I think in the future we should remove Calva's version and use lsp's.

bpringe commented 3 years ago

We still don't use clojure-lsp's feature for this, so I think this should stay open, unless you think we shouldn't use clojure-lsp's feature.

See here: https://github.com/BetterThanTomorrow/calva/blob/5afd24b01de27046ee1c2422b5dbdfb27007a0d7/src/lsp.ts#L21

PEZ commented 3 years ago

I haven't formed an opinion where this should be handled. We can leave this issue open until we have pondered it sufficiently.