search

BetterThanTomorrow / calva

Clojure & ClojureScript Interactive Programming for VS Code
https://marketplace.visualstudio.com/items?itemName=betterthantomorrow.calva
Other
1.67k stars 217 forks source link

Add Missing Require refactoring includes metadata #914

Open fonghou opened 3 years ago

fonghou commented 3 years ago

Thank you @bpringe, @ericdallo for coming up the fix for clojure-lsp on Windows!

I just tried it, noticed a minor issue. Add Missing Require included metadata in require.

image

PEZ commented 3 years ago

I have also seen this happen in dev, when I added the refactorings. But then it stopped behaving like that, and I thought I had found the right settings to prevent it...

ericdallo commented 3 years ago

Never saw this behaviour before 🤔

bpringe commented 3 years ago

https://github.com/clojure-lsp/clojure-lsp/issues/120 Here's a related issue but it looks like it was believed to be fixed. However, it must not be.

ericdallo commented 3 years ago

I could not reproduce these issues, do you have a sample where I can reproduce it using lsp-mode?

bpringe commented 3 years ago

Might just be on Windows. I'll test when I can get to this, if no one else does before me.

fonghou commented 3 years ago

I can't reproduce with calva 2.0.143 + clojure-lsp 2020.12.31-17.22.22 on windows anymore. It's a low priority.

PEZ commented 3 years ago

It is not just on Windows. I've seen it on Mac. Now idea how to reproduce it though. But it is very probably upstream (clojure-lsp or beyond).

ericdallo commented 3 years ago

It can be an issue on clojure-lsp, but I have never seen that, and it's quite hard fix it without a sample to reproduce it.

PEZ commented 3 years ago

Indeed. I will update if I encounter this again. But as things stand now, none of us can't really do anything about it.

bpringe commented 1 year ago

Has anyone seen this in a while? If not, I think we can close this.