search

BetterThanTomorrow / calva

Clojure & ClojureScript Interactive Programming for VS Code
https://marketplace.visualstudio.com/items?itemName=betterthantomorrow.calva
Other
1.68k stars 217 forks source link

Expose debugger for other programs use Calva debugger #936

Open ericdallo opened 3 years ago

ericdallo commented 3 years ago

It'd be great if you expose the calva calva-debug.ts in the .vsix generated file, this way other programs like dap-mode could use that.

This way we could have a separate executable(via node) of the debugger server following the DAP protocol.

@bpringe took a look and some local changes to generate the .vsix with the debugger, but we could not make it work with just a node extension/out/debug.js

It'd be great if we could make this happen, this way we could have clojure debugging in Emacs using Calva's debugger 🤯 In the future we could move the debugger logic to another repo if it makes sense ;)

ericdallo commented 3 years ago

This is an example of an extension exposing the debugger program that we already use in lsp-dart here

bpringe commented 3 years ago

I think in the long run it makes sense to move it to its own repo so other editors can use it, though this is low priority for us. But a PR would be welcome if you or anyone else can get it working with node.

It may just be some more changes to the webpack config. Comparing to other debuggers like Dart's that are used in this way should lead to a solution.

ericdallo commented 3 years ago

Thanks @bpringe ! Sure, how do you generate the .vsix so I can make my own tests?

bpringe commented 3 years ago

You can download vsce via npm, and then run vsce package. See #935 for a starting point.

ericdallo commented 3 years ago

Thanks! will take a look

awwalker commented 2 years ago

@ericdallo did you ever figure this out? I'm also interested in seeing the Calva debugger as a standalone dap plugin!

ericdallo commented 2 years ago

No @awwalker, I figured it would make sense to have a DAP server separated using cider-nrepl separately or even just use java jdtls debugger

bpringe commented 2 years ago

I figured it would make sense to have a DAP server separated using cider-nrepl separately or even just use java jdtls debugger

@ericdallo Can you elaborate more?

What do you mean by using cider-nrepl separately?

How would the java jdtls debugger be used? Are you referring to this project? https://github.com/eclipse/eclipse.jdt.ls

Potentially unrelated: I was thinking about how a separate server might work for Clojure debugging. Calva's debugger uses cider-nrepl for its debugging functionality, and I believe it needs to be used from the user's REPL connection, because it needs to know what forms are instrumented for debugging (and maybe some other info). Maybe the server would connect to the same nrepl server that the user is using?