New example: toggle between interface and implementation

BetterThanTomorrow / joyride

Making VS Code Hackable like Emacs since 2022

https://marketplace.visualstudio.com/items?itemName=betterthantomorrow.joyride

Other

458 stars 17 forks source link

New example: toggle between interface and implementation #167

Closed svdo closed 10 months ago

svdo commented 10 months ago

Please answer the following questions and leave the below in as part of your PR.

[X] I have read the developer documentation.

I didn't do the following, since this is just a new example:

[ ] This PR corresponds to an issue with a clear problem statement.
[ ] This PR contains a test to prevent against future regressions
[ ] I have updated the [Unreleased] section of the CHANGELOG.md file with a link to the addressed issue.

PEZ commented 10 months ago

Thanks! 🙏

I only had a small suggestion about how to make the script REPL-loadable without jazzing with state.

svdo commented 10 months ago

Perfect Peter, no I didn't have a reason for that, just some very old example code that got copied over.

svdo commented 10 months ago

Is there some require that I can add to fix the linter warnings about the joyride ns?

svdo commented 10 months ago

Hmm, actually, now I get:

ERROR: Run Failed: toggle_between_interface_and_impl.cljs Could not resolve symbol: joyride/invoked-script

PEZ commented 10 months ago

Is there some require that I can add to fix the linter warnings about the joyride ns?

You need to require joryride.core. Not just to please the linter. See my comment in the code.

svdo commented 10 months ago

Ok that was also a left-over from the original starting point that I took.

By the way I converted this PR to draft, because I've been adding support for more cases in my dev env, so I'll update it soon. For example, when you're in interface.clj it will find a list of candidates to go to, go to the first one if there is only one, and display a quick pick if there are more.

I may also add support for creating the file that you should go to if it doesn't exist yet.

PEZ commented 10 months ago

Ah, I wondered about the draft thing when I got notified. 😄 That's awesome. I'm here if you need a second pair of eyes on anything, or wonder about something.

svdo commented 10 months ago

I added another feature; it's not "complete" but good enough for me at the moment, and I don't expect to have time to further improve it in the short run. I'll finish the PR for now so that others may also benefit from it. If I make more improvements in the future, I'll create a new PR to this repo as well.

PEZ commented 10 months ago

Sounds great. Not sure you meant that this PR is good to go now? Let me know when you think it is and I'll have a look and probably merge.

svdo commented 10 months ago

Yeah please do. It's as ready as it's going to be for now, so as far as I'm concerned this can be reviewed and merged. Thanks!