Add `tap>` et al - Githubissues

BetterThanTomorrow / joyride

Making VS Code Hackable like Emacs since 2022

Other

458 stars 17 forks source link

Closed PEZ closed 9 months ago

PEZ commented 9 months ago

This replaces PR:

113
[x] I have read the developer documentation.
[x] This PR corresponds to an issue with a clear problem statement.
[x] This PR contains a test to prevent against future regressions
[x] I have updated the [Unreleased] section of the CHANGELOG.md file with a link to the addressed issue.

borkdude commented 9 months ago

After the one comment, lgtm

PEZ commented 9 months ago

Thanks! Can you have a look again that I got it right? I'm not super savvy with async tests.

PEZ commented 9 months ago

We have an deftest-async macro that maybe should be used...

PEZ commented 9 months ago

I changed so that we now use the deftest-async macro, which ensures we call done properly also on errors.