Closed djblue closed 9 months ago
LGTM!
Thanks, @djblue!
This enables the user to write scripts in .cljc
files. I just tried and it works. Also as an automated test. With a vscode-test-runner/workspace-1/.joyride/scripts/a_cljc_script.cljc
script like this:
(ns a-cljc-script)
:a-cljc-script
And a test like this:
(deftest-async run-a-ws-cljc-script
(testing "Runs a workspace cljc script"
(p/let [result (vscode/commands.executeCommand "joyride.runWorkspaceScript" "a_cljc_script.cljc")]
(is (= :a-cljc-script
result)))))
However, .cljc
scripts do not show up in the *Run Workspace/User Script... menus. Which is inconsistent, I think. Can you add? I don't think there's a convenient way to test this with an automated test, so unless you know of a way, skip that.
@PEZ Good catch. updated the PR to include the test and enabled loading cljc scripts as well 👌
Please answer the following questions and leave the below in as part of your PR.
[x] I have read the developer documentation.
[x] This PR corresponds to an issue with a clear problem statement.
[x] This PR contains a test to prevent against future regressions
[x] I have updated the [Unreleased] section of the CHANGELOG.md file with a link to the addressed issue.