Add uuid constructor to sci

BetterThanTomorrow / joyride

Making VS Code Hackable like Emacs since 2022

https://marketplace.visualstudio.com/items?itemName=betterthantomorrow.joyride

Other

469 stars 17 forks source link

Add uuid constructor to sci #185

Closed djblue closed 8 months ago

djblue commented 8 months ago

Please answer the following questions and leave the below in as part of your PR.

[x] I have read the developer documentation.
[ ] This PR corresponds to an issue with a clear problem statement.
[ ] This PR contains a test to prevent against future regressions
[x] I have updated the [Unreleased] section of the CHANGELOG.md file with a link to the addressed issue.

borkdude commented 8 months ago

LGTM!

PEZ commented 8 months ago

LGTM too!

The reason the tests fail is that something has changed in how docker images are pulled (or something) so that Google does not get away with their non-standard/deprecated signing (or something). I'll fix this on the trunk (same way as I “fixed” it for Calva.) and you can merge it in here so that we can see the tests pass before merging the PR.

PEZ commented 8 months ago

Fixed: https://app.circleci.com/pipelines/github/BetterThanTomorrow/joyride/480/workflows/8f32af8d-f159-49a5-b822-673fd772f464

PEZ commented 8 months ago

Thanks! 🎸