search

BetterTheWorld / react-native-button-sdk

3 stars 0 forks source link

Add the final class or a function to implement the Button SDK's Report Impression Views #2

Open smlarkin opened 4 years ago

smlarkin commented 4 years ago

In Button's Docs, there is a Report Impression Views section:

This could be a single class ImpressionView that is initialized withcreativeType types:

- hero carousel
- list
- grid
- detail
- other

An single method track would be needed with these params:

- url
- visibleRateType
- visibleRate
- offerId

Or this could be purely functional with a curried function / partial application for ImpressionView that does the same thing as the class.

I am happy to submit it PR with this feature if you can adjust any of the native code / bindings I don't get right.

Cheers!

codybrouwers commented 4 years ago

Hey @smlarkin thanks for the suggestion, apologies for the delay in responding. I need to update the SDKs in the package this week so will also look at doing what you suggested!