Betterbird / thunderbird-patches

Betterbird is a fork of Mozilla Thunderbird. Here are the patches that provide all the goodness.
Other
468 stars 20 forks source link

Flexible spaces disappear from Unified Toolbar after switching to 'default toolbar' tabs #194

Closed dillenger closed 1 year ago

dillenger commented 1 year ago

Flexible spaces disappear from the Unified Toolbar after switching to some tabs, all buttons then align at the end. Tabs where this happens include add-on tabs like ThirdStats and uBlock Origin and the Troubleshooting Information tab. Apparently these tabs do not have their own Unified Toolbar Space, they only show the default space.

Betterbird commented 1 year ago

And that doesn't happen in TB? Have you filed an upstream bug?

dillenger commented 1 year ago

Betterbird only, if it happened in Thunderbird I would have filed a bug there.

Betterbird commented 1 year ago

Can you please post some screenshots. We're not aware of any code changing the behaviour of the unified toolbar, well, apart from moving it under the menu bar. We also have some tab restoration changes, but that shouldn't affect the toolbar.

dillenger commented 1 year ago

Ok 4 screenshots with all addons except uBlock Origin & Profile Switcher disabled. Flexible spaces are not completely gone but definitely smaller and everything is aligned at the end of the toolbar. Customize Toolbar: Screenshot 2023-09-03 133117 - customize Buttons OK: Screenshot 2023-09-03 133203 - buttons ok uBlock Dashboard: Screenshot 2023-09-03 133259 - ublock dashboard Buttons moved to end: Screenshot 2023-09-03 133455 - buttons moved to end

Betterbird commented 1 year ago

This will be difficult to fix since it doesn't reproduce here:

image image image image

You can see that the first and last picture are the same.

So what is the minimal configuration to reproduce this on a new profile, preferably without using any add-on? We're also not convinced that this isn't a TB issue since we've surely haven't changed any code to render the unified toolbar, at least not deliberately.

What happens after a restart? Does it become good again?

dillenger commented 1 year ago

I will try a fresh profile, it is ok after restart and after changing anything in Customize Toolbars.

dillenger commented 1 year ago

Also happens with a fresh profile, no add-ons. Customize toolbar, remove the search box and add Get Messages and Write buttons to the start of the toolbar. Now open Help > Troubleshooting Information. Go back to the previous tab, the buttons have moved to the right. This doesn't happen on Thunderbird.

dillenger commented 1 year ago

Apparently a hidden search-bar item is added which pushes the rest to the end:

image

Betterbird commented 1 year ago

Thanks, we can see it now. The search item is there in TB: image It has hidden="" but it his hidden.

In BB it looks the same: image

We can't detect any difference, however, the thing is only semi-hidden, still occupying the allocated space.

Betterbird commented 1 year ago

It's this CSS: image

Taking disiplay: list-item removes it from the space calculation.

Betterbird commented 1 year ago

Found it: .\features\22-feature-vertical-tabs.patch:+ display: list-item;

Betterbird commented 1 year ago

Fixed with commit referenced above. Included in this build: https://www.betterbird.eu/downloads/115-Preview/betterbird-115.2.0-bb10-latest-build4.en-US.win64.installer.exe

dillenger commented 1 year ago

It's fixed, thanks.