search

Betterbird / thunderbird-patches

Betterbird is a fork of Mozilla Thunderbird. Here are the patches that provide all the goodness.
Other
468 stars 20 forks source link

Fix window activation #206

Closed dark-penguin closed 11 months ago

dark-penguin commented 11 months ago

A workaround for a GTK limitation Closes #202

Betterbird commented 11 months ago

You can't edit patches like this. If you remove one line and add two, the patch won't apply. You need to change the numbers in the hunk header as well. Anyway, we don't leave old code commented out.

I'll do you a build with your change.

dark-penguin commented 11 months ago

I actually wondered about that - what you can change in a patch and what you can't. :) Now I know.

Betterbird commented 11 months ago

Plus there are two gtk_window_present() calls in the code. One to just raise and one when bringing back from being minimised and hidden. Looks like you hit the latter one. I'll change both.

dark-penguin commented 11 months ago

Actually, I've found it in three files:

13-feature-linux-minimise-to-tray-fix-activate.patch
13-feature-linux-minimise-to-tray-restore-window.patch
13-feature-linux-minimise-to-tray.patch

But I don't know how are they applied, so it could turn out to be three calls.

Betterbird commented 11 months ago

Yes, the three files show the evolution of this functionality. Now it's all merged together here: https://github.com/Betterbird/thunderbird-patches/blob/b54ab1cf3ae39de4ec81eb910d3317dafb26ab67/115/features/13-feature-linux-minimise-to-tray.patch#L320 (that's the line you changed)