Betterbird / thunderbird-patches

Betterbird is a fork of Mozilla Thunderbird. Here are the patches that provide all the goodness.
Other
455 stars 20 forks source link

Crash after waking up PC from sleep - related to Gnome? #235

Closed DeN-AlB closed 6 months ago

DeN-AlB commented 8 months ago

Betterbird: 115.5.2-bb20 (64-Bit) OS: Fedora 39 Workstation (Gnome)

Yesterday, I updated flatpak version of Betterbird to 115.5.2-bb20 (64-Bit). Since then, I got 2 crashes already when waking up PC from sleep with Betterbird minimized in taskbar.

Here's the log. Maybe it helps to find the issue.

ccpp-2023-12-14-17:56:16.280692-15539.zip

I left away the coredump-file, because it's too big for uploading.

Betterbird commented 8 months ago

We had a similar support case the other day: "Crash after a few hours of use", that was reported for Fedora 38. The answer of the FlatPak maintainer @mfs was:

for debugging you can install the eu.betterbird.Betterbird.Debug flatpak and then follow this guide to run Betterbird under gdb: https://blogs.gnome.org/mclasen/2017/01/20/debugging-a-flatpak-application/ There is no need to build the app yourself. Some more thoughts: Is it always a few hours until the crash or does the crash correlate to some event like receiving new mail? When did you start having this issue? Is there a version of the flatpak that has worked fine?

DeN-AlB commented 8 months ago

Is it always a few hours until the crash or does the crash correlate to some event like receiving new mail?

I sent my PC to sleep for some hours. And after waking up with BB minimized in tray, the issue occurs. Yes, when waking up from sleep BB is getting new emails.

When did you start having this issue? Is there a version of the flatpak that has worked fine?

Yesterday, after updating flatpak version to 115.5.2-bb20 (64-Bit). With version 115.5.1-bb19 (64-Bit) this issue wasn't there.

DeN-AlB commented 8 months ago

Still getting these crashes. Sometimes they appear without sending the PC to sleep. I click on an email, Betterbird freezes and then crashes.

Am I the only one getting these crashes? :/

Betterbird commented 8 months ago

Am I the only one getting these crashes? :/

Hard to say. There are not a lot of reports about crashes. The support case mentioned earlier on and Issue #153.

DeN-AlB commented 8 months ago

Maybe it's a TB-thing and not an BB issue. Let's wait for the next release and hopefully my crashes are gone then ... ;)

Betterbird commented 8 months ago

I'm pretty sure we didn't change anything that would cause those crashes, or maybe the system tray integration. You could try switching that off:

Relevant preferences: System tray: mail.biff.show_tray_icon (has UI) System tray always: mail.biff.show_tray_icon_always (no UI) Minimize to tray: mail.minimizeToTray (has UI) Linux only: mail.minimizeToTray.supportedDesktops ("kde,gnome,xfce,mate") and mail.minimizeToTray.desktopsGtkWindowPresentWithTime (special activation, "mate") (no UI) Start minimized: mail.startupMinimized (no UI) Show new count: mail.biff.use_new_count_in_badge (has UI) Only count unread message in inboxes: mail.notification.count.inbox_only (no UI)

Clear the first two prefs.

DeN-AlB commented 8 months ago

I'm using mail.minimizeToTray and mail.biff.show_tray_icon_always. Both I set to their default of false now.

Let's see if this helps ...

Betterbird commented 8 months ago

Yes, make sure that the system tray icon doesn't show at all. That's really the only difference to TB that I can think of that could cause an issue. If it still crashes after a while, please switch to TB and check whether that crashes, too.

BTW, debugging instruction are in the second comment.

DeN-AlB commented 8 months ago

Yes, make sure that the system tray icon doesn't show at all.

There isn't a system tray icon anymore. But I'll minimize BB into the dash now.

DeN-AlB commented 8 months ago

No crash since disabling the tray icon. There is only a tray icon, when I got new email.

Maybe the tray icon is the reason?

Betterbird commented 8 months ago

Looks like it, doesn't it? You can leave the machine sitting there with an unread mail and when you come back, see whether it crashes.

DeN-AlB commented 8 months ago

I already did so. Was away from the PC and when I came back there were new emails and the tray icon available.

Betterbird commented 8 months ago

But the original comment talked about "sleep". So did it sleep in this case?

DeN-AlB commented 8 months ago

There were situations where the PC was sleeping. When waking up the PC there wasn't any crash.

But let me test further. Will see in the next days ... ;-)

DeN-AlB commented 8 months ago

I shouldn't have written that. BB was minimized into the dash. Then an email arrived and I saw the tray icon appearing. Bam ... BB crashed down. I had to restart BB again.

It looks like that the tray icon could be the reason for my crashes ...

Betterbird commented 8 months ago

Can you run it in the debugger to find out where it crashes?

DeN-AlB commented 8 months ago

I don't know how to do it ... What do I have to do?

Betterbird commented 8 months ago

See the second comment above.

DeN-AlB commented 8 months ago

Looks a bit complicated ... I'll try in the next days if I get it to run.

icolquhoun commented 7 months ago

I have been experiencing this too for at least the last 2 flatpak releases. I don't let my machine sleep, but I do lock the screen when I walk away. Everytime after returning from a screenlock, whenever new mail arrived, Betterbird would crash. I've disabled the tray icon and tested a lock followed by new mail arriving and so far, it seems like it isn't going to crash. I'm hoping that that's cured the problem. I'll update if it hasn't.

Betterbird commented 7 months ago

Only the FlatPak crashes or also the .tar.bz2? Which desktop (as in KDE, Gnome, Xfce, Mate, etc.) are you using?

icolquhoun commented 7 months ago

I haven't tried anything but the FlatPak. I'm on Pop!_OS (pretty much Gnome).

DeN-AlB commented 7 months ago

Sorry for the delay, but I was a bit busy in the last days ...

For me, the issue is solved. I switched from Gnome to KDE and since then there wasn't any crash. I think this is an issue on Gnome. There isn't a system tray with tray icons, and you only get one if you are using an extension. Maybe this could be the reason.

Also, I used a Gnome patch to get Adaptive Sync that isn't available out of the box and as I read on Nobara website, this implementation could break the system tray.

https://nobaraproject.org/2023/12/26/december-26-2023/

VRR (Variable Refresh Rate/Freesync) functionality. Gnome currently still requires patched-in VRR functionality. The pending MR has been waiting 3 years, and even doing so still breaks the system tray.

janmechtel commented 7 months ago

I also have crashes "sometimes" with new emails on Fedora Gnome Wayland. I'll observe whether it's related to locking + experiment with the tray icon.

Neriderc commented 7 months ago

Just checking in to say I also have had many crashes during sleep over the past few weeks or more. Also using the flatpak installed via the gnome software centre on Fedora 38. I will experiment with the system tray.

janmechtel commented 7 months ago

I've disabled the tray icon but just had another crash, not sure if there is any useful info in the crash details: image

Betterbird commented 7 months ago

Please keep in mind that TB and FF have crashes that BB inherited. If the crashes persist, you should see whether they can be reproduced on TB and then submit a crash report.

I'm under the impression that Wayland isn't even supported yet, since there are: https://bugzilla.mozilla.org/show_bug.cgi?id=635134 https://bugzilla.mozilla.org/show_bug.cgi?id=1542587

DeN-AlB commented 7 months ago

I'm under the impression that Wayland isn't even supported yet

Just want to say that I'm on KDE Wayland at the moment. No crashes since I use that desktop environment. Although, tray icon is enabled completely.

Betterbird commented 6 months ago

I'm closing this in favour for Issue #266. It's pretty clear that this is triggered by Gnome + Wayland.

Betterbird commented 6 months ago

Should be fixed in 115.8.0-bb24.

DeN-AlB commented 6 months ago

Thanks for the hard work, @Betterbird . :+1: