Betterbird / thunderbird-patches

Betterbird is a fork of Mozilla Thunderbird. Here are the patches that provide all the goodness.
Other
455 stars 20 forks source link

Implementation of close to tray, while minimize not to tray #244

Closed knakamura8 closed 3 months ago

knakamura8 commented 7 months ago

I think that there should be a feature by which BB can run persistently in the system tray (at least in Windows), while retaining normal minimize to taskbar (not tray) functionality.

I am aware of the built-in functionality of minimize to tray, built-in persistent tray icon, as well as the close to minimize extension. I have also read tickets #190 and #111.

The typical workflow for apps that support close to tray, imho, is that minimize functionality works normally (i.e. to taskbar), and close will close the app to the system tray. Currently, the user has to choose between whether or not to have taskbar functionality with no close to tray, or close to tray with no taskbar functionality (via the chaining of close to minimize -> minimize to tray -> tray icon, even with always persist tray icon enabled).

My proposal is an inclusion of close to tray, which functions independently of minimize to tray. This way, users can choose which functionality (maybe even both!), they wish to enable. As such, I propose the addition of a column on the System tray matrix, of the nature of Close to tray. i.e.

OS / Desktop System tray System tray always Tooltip with folder list Minimize to tray Close to tray
Windows Yes Yes Yes Yes Hopefully!
Linux / KDE Yes Yes Yes Yes Hopefully!
Linux / Gnome Yes Yes No Yes(*) Hopefully!
Linux / Cinnamon Yes Yes Yes No Hopefully!
Linux / Mate Yes Yes Yes Yes(**) Hopefully!
Linux / Xfce Yes Yes Yes Yes Hopefully!
Betterbird commented 7 months ago

So basically you want to have what this add-on https://addons.thunderbird.net/en-us/thunderbird/addon/minimize-on-close/ does "out of the box", but the "close minimise" should go to the tray always. Right?

knakamura8 commented 7 months ago

short answer: Yes, exactly.

Thank you for the rapid response! Well, considering that the extension already handles minimize on close, of course it would not be strictly necessary to re-implement that within BB directly, though it would be "nice to have", imho.

The workflow suggestion is more that I think "close to tray" is useful for apps that run persistently, such as an email program which notifies the user of incoming mail. Chat, RSS, and file transfer programs are other types of programs which tend to support this type of "close to tray" functionality, while retaining normal "minimize to taskbar" functionality. For example, if a user is tabbing between taskbar windows, including minimizing them when writing an email or using a program such as a chat program, then having the window be minimized to tray is inconvenient. However, upon completion of the active tasks at hand, it is convenient to close the program to tray, and still have the program waiting on incoming emails, messages, feeds, files, etc.

Currently, when using that extension, it essentially must be chained to "minimize to tray" to allow for "close to tray" to work. Whereas the workflow I describe divorces the two functions, making them independent of one another. I apologize if I am not expressing myself clearly. Also, I am unsure as to how much complexity this might entail. That having been said, it is a common feature in such "persistent" type programs, both in Windows and in GNU/Linux distributions. A stretch/reach goal would perhaps be to just include both "minimize to tray" and "close to tray" functionalities as separate check boxes within BB itself, which would also obviate needing the extension at all.

As a side note, "close to tray" would have to automatically enable the tray icon if persistent tray icon functionality is not already enabled.

Betterbird commented 7 months ago

Why don't you suggest to the author of the "Minimize on close" @rsjtdrjgfuzkfg that he implement an option to "minimize to tray on close"? That would be much less coding effort that us having to integrate his add-on and then add this option?

knakamura8 commented 7 months ago

OK, I will do that, thank you!

Betterbird commented 3 months ago

We haven't had any further feedback here. Looks like using the add-on plus the "minimise to tray" function in BB already does what you want. We tested it on Windows.

Note that "minimise to tray" doesn't work on Wayland, see Issue #279.

slikie commented 1 month ago

Wayland/Sway/Hyprland doesn't seem to work with either of these?

Betterbird commented 1 month ago

Anything Wayland doesn't work, see Issue #279.