Betterbird / thunderbird-patches

Betterbird is a fork of Mozilla Thunderbird. Here are the patches that provide all the goodness.
Other
455 stars 20 forks source link

Upstream bug 1872789: Calender only searches back one year #251

Closed Betterbird closed 1 month ago

Betterbird commented 7 months ago

https://bugzilla.mozilla.org/show_bug.cgi?id=1872789 regressed here: https://bugzilla.mozilla.org/show_bug.cgi?id=1844408

https://www.reddit.com/r/Betterbird/comments/198p0x4/how_can_i_return_this_important_calendar_feature/

Will become relevant for BB 128.

Mobilize1696 commented 7 months ago

Thank you for logging! I don't know when you plan to release 128 beta. When should I look back for an update?

Betterbird commented 7 months ago

BB 128 beta comes in May or June 2024.

Mobilize1696 commented 7 months ago

OH great! Apologies, but I cant' find downloads for current BB betas, only the stable versions. Could you please provide a link?

Betterbird commented 7 months ago

Generally there are no betas. We'll do a BB 128 beta in May or June 2025 2024.

Mobilize1696 commented 7 months ago

BB 128 beta comes in May or June 2024.

Oh, was 2024 a typo then?

Betterbird commented 7 months ago

No, 2025 was the typo. The next ESR 128 comes in June/July 2024 and the beta a month before.

Mobilize1696 commented 7 months ago

Awesome! Look forward to updating then.

Betterbird commented 4 months ago

Maybe the TB folks are going to implemente something in https://bugzilla.mozilla.org/show_bug.cgi?id=1855900

Mobilize1696 commented 4 months ago

Maybe the TB folks are going to implemente something in https://bugzilla.mozilla.org/show_bug.cgi?id=1855900

Thanks! After looking at it, it seems just as old and inactive as mine. Is there a reason you believe this one will lead to an implementation from them?

Betterbird commented 4 months ago

We'll see, if not, we'll do something.

Mobilize1696 commented 2 months ago

It's a month before the BB 128 ESR. Is there an update on either your implementation or TB's?

Betterbird commented 2 months ago

Thanks for the reminder. As expected, the TB folks haven't done anything. We'll fix it for 128.

It's a month before the BB 128 ESR.

Well, the official release date is the 9th of July 2024. I doubt that it will be released then, since due to a broken backend, 128 is unusable:

Folder corruption since version 122: https://bugzilla.mozilla.org/show_bug.cgi?id=1890230 Folder compact broken since version 122: https://bugzilla.mozilla.org/show_bug.cgi?id=1878541 POP message corruption since version 122: https://bugzilla.mozilla.org/show_bug.cgi?id=1888790 Also, they rewrote folder compact (https://bugzilla.mozilla.org/show_bug.cgi?id=1890448) so it doesn't work now: https://bugzilla.mozilla.org/show_bug.cgi?id=1900172.

Our best estimate is that 128.3 in October may be usable.

Mobilize1696 commented 2 months ago

Okay, since October is still quite awhile away, do you think there is still a likelihood that despite the other bugs, TB might also fix the calendar issue by then?

(Edited to fix formatting)

Betterbird commented 2 months ago

Unlikely.

Mobilize1696 commented 2 months ago

Okay, thank you for taking this on then!

(Edited to fix formatting)

Betterbird commented 2 months ago

Looks like the TB folks are fixing this in bug https://bugzilla.mozilla.org/show_bug.cgi?id=1855900 now.

Mobilize1696 commented 2 months ago

Thanks for updating! To me, it just looks like someone keeps starting a repeat bug every few months. I can't see anyone saying they will actually fix it. But I replied to promote it since my bug was marked as a dupe.

Betterbird commented 2 months ago

Don't worry, you will get something workable. The new bug has a fix attached which is waiting for review. If that's not enough, we'll improve it.

Mobilize1696 commented 2 months ago

Okay, I'm not understanding the programming lingo on there. When should I check in? Or will you update like before?

Betterbird commented 2 months ago

If you are Sanded7279 on BMO, you will get updates on the bug. If two years back is not enough, we can increase that value. Surely 100 years ago you wouldn't have had any appointments (unless you're the Flying Dutchman).

Mobilize1696 commented 2 months ago

I have important dates for memories including medical records that go back 40+ years that I've entered into my calendars. I need the whole history to be accessible as it was before the feature was removed.

Okay, please keep me updated if you find a significant development or workaround.

(Edited to fix formatting) - When you answer via e-mail, please make sure only to send the relevant text, I've had to edit three replies so far.

Betterbird commented 2 months ago

If the TB folks stick with the 2-year limit, we'll likely increase to 100 years. Let's assume that no one gets older than 110 years and that in the first 10 years they don't book any appointements.

If you have such important calendar content, please make sure it's duly exported and backed up.

UPDATE: Looking at the code the TB folks are proposing, it looks like the search would start with "date 0", so everything after 1970 should be covered. Most computing is like that.

Mobilize1696 commented 2 months ago

Thank you, I really appreciate you.

Betterbird commented 1 month ago

Good Lord, https://bugzilla.mozilla.org/show_bug.cgi?id=1855900 stalled 😢

Betterbird commented 1 month ago

We looked at the fix in the bug and it looks good to us, We'll ship it in the next 128 build.

Note that TB's technical director got it wrong, see: https://phabricator.services.mozilla.com/D212771

Quote: This is a feature that has been broken since 115 and we didn't get many duplicates.

That's wrong. This feature has worked from day one until it was removed here https://bugzilla.mozilla.org/show_bug.cgi?id=1844408 in version 118. So it clearly worked in 115.

Mobilize1696 commented 1 month ago
  Hi! Thanks for update. I'm confused. 
  Is there simultaneous development by both apps to fix this bug for
  version 128? 

  And TB: https://phabricator.services.mozilla.com/D212771:

  "This is a
  feature that has been broken since 115 and we didn't get many
  duplicates.
  We're gonna start a complete calendar rebuild around September
  so it's not worth trying quickly fix a niche feature that was
  removed due to multiple issues.
  Let's defer this to after ESR."

    - Thanks

EDITED with quoted part removed.

Betterbird commented 1 month ago

Yes. One TB developer suggested a solution, two others rejected it with the following arguments:

  1. WRONG: The feature has been broken already in 115 (like for more than a year) and no on complained.
  2. BAD ARGUMENT: Calendar will be overhauled in September (2024?).
  3. Technical nits.

Since the TB folks are usually not sticking to their self-declared aims, maybe users will see the feature restored at some stage in 2025 or 2026, or not at all. Hard to predict.

Mobilize1696 commented 1 month ago
  Ah, okay, they're just quack quack quacking
  themselves up and down into the ground over and over, so now
  you've decided to actually soar up into the clouds, because you're
  tryin' to be the Better bird! Got it! 

EDITED and quoted content removed.

Betterbird commented 1 month ago

Done. Will ship in the next 128 release, likely in 7-10 days.

Mobilize1696 commented 1 month ago

Muchos Gracias!

EDITED: quoted content removed.

Betterbird commented 1 month ago

If you're on Windows and want to try it: https://www.betterbird.eu/downloads/get.php?os=win&lang=en-US&version=future

Mobilize1696 commented 1 month ago

Thanks but I need a different version, I can't find this 128 version in portable and with GB language.

EDITED: quoted content removed.

Betterbird commented 1 month ago

Those versions are coming in a month or so.

Mobilize1696 commented 3 weeks ago

Hi! Whilst waiting for portable version of Betterbird 128, I was notified that an addon was made as a workaround, to show "all events" which the German developer said is limited to 50years. I've tried it on TB ESR 128.01 portable and can confirm that it actually searches up to both 50 years ago in the past and 50 years in future. Link below: https://connect.mozilla.org/t5/discussions/calendar-search-function-in-nebula/td-p/63744

Betterbird commented 3 weeks ago

Next we will need an add-on to send mail :cry:

BTW, to make a portable, just grab any portable version, extract it. Then get the 128 Windows installer (.exe), open with 7Zip and replace the "core" folder in your portable version with the "core" folder in the installer.