Complex rule doesn't get restored correctly

[Betterbird]

Start with

which in msgFilterRules.dat is stored as "AND (to,contains,A) AND (subject,contains,A) OR [to,contains,B) AND (subject,contains,B] OR [to,contains,C) AND (subject,contains,C]"

That's wrong, so the filter is restored to

Starting with

is stored as "AND (to,contains,A) AND (subject,contains,A) AND [subject,contains,dummy-dummy-dummy) OR [to,contains,B) AND (subject,contains,B] OR [to,contains,C) AND (subject,contains,C]]"

and that gets restored properly.

[Betterbird]

We took a look at our test data, since we had tested some scenarios. Turned out that we had a non-sensical test case:

That actually works, but as soon as you switch "all" to "any" in the inner groups, it all falls apart. So much for letting the developers do the testing :sob:

As an immediate mitigation we will disallow groups following groups, like this:

So into a group, you need to add a term first before starting another group. That's along the lines of your suggestion (quote): I would suggest prohibiting entering second-level nested terms at all.

@kupietools: Please voice objections now or it will ship on the coming Tuesday, 23rd Jan. 2024.

[ThiloteE]

I have following filter: Will it still work? Saw this issue too late. I am now afraid of updating to 115.7.0-bb23 (23 January 2024)

[Betterbird]

Yes, that will work. What doesn't work and never worked is this:

[ThiloteE]

Thank you :-)