Betterbird / thunderbird-patches

Betterbird is a fork of Mozilla Thunderbird. Here are the patches that provide all the goodness.
Other
424 stars 18 forks source link

Message header font css doesn't effect changes #277

Closed PaduaPlay closed 4 months ago

PaduaPlay commented 4 months ago

/ Tweaks to header pane / .message-header-label { color: red ! important; font-weight: bold ! important; }

This is from https://www.betterbird.eu/expert-tips/userChrome.css and doesn't effect any changes to the message header.

Is there any change to the message header element name or syntax for this?

Betterbird commented 4 months ago

In general, for 115 you should be looking at https://www.betterbird.eu/expert-tips/userChrome-115.css. However, this still works:

/* Tweaks to header pane */
.message-header-label {
  color: red ! important;
  font-weight: bold ! important;
}

image

Have you enabled pref toolkit.legacyUserProfileCustomizations.stylesheets ?

In general, please don't file support requests as GitHub tickets.

PaduaPlay commented 4 months ago

Thanks very much for the response.

Posted here because the example css did not work and thought that perhaps with the new rev the element name had changed. Apologies if it was not the forum protocol. Noted about not posting support questions as 'issues' on GitHub and will do.

Just started using Betterbird 115.8.1-bb25 and toolkit.legacyUserProfileCustomizations.stylesheets is already set to true.

/ Tweaks to header pane / .message-header-label { color: red ! important; font-weight: bold ! important; }

(which is the same in https://www.betterbird.eu/expert-tips/userChrome-115.css and https://www.betterbird.eu/expert-tips/userChrome.css), does not change anything in the message headers shown on the message pane.

Of course, this is just a minor tweaking preference, so don't wish take up valuable dev time.

Thanks again. messageheader

Betterbird commented 4 months ago

... does not change anything in the message headers shown on the message pane.

It does. However, in your screenshot we don't see the "normal" Betterbird (or Thunderbird) message header. Headers are uppercase, there is no folder: header, and the icons shown don't belong to BB/TB. This comes from the Conversations add-on. Clearly the CSS aimed at changing the BB/TB headers won't have an effect on the stuff the add-on displays.

You need to use the inspector (Tools > Developer Tools > Developer Toolbox) to analyse the CSS you want to change. We find Conversations quite invasive, so we installed it on a test profile. The headers are displayed when you click the (i) icon. The inspector shows this: image

So maybe this CSS will work:

/* Tweaks Conversations headers */
.detailsLine {
  color: red ! important;
  font-weight: bold ! important;
}
PaduaPlay commented 4 months ago

@Betterbird, I very much appreciate your taking the time.

The .message-header-label tweak does not work even after disabling the 'Conversations' add on (which I have found very useful to link messages in various folders) and restarting Betterbird. The only addon enabled was the 'Lightning in a new tab'.

Neither does the .detailsLine tweak work with the 'Conversations' addon enabled.

Looked up the dev tools / toolbox. Just felt that there the time and effort needed to effect this minor tweak seems a bit disproportionate. :) and will continue to try out Betterbird with the message headers as it is at this time.

A WYSIWIG UI customization tool would be a great companion app and, along with a forum in English would be valuable options and one that many would be happy to subscribe + donate to.

Thanks again.

Betterbird commented 4 months ago

The .message-header-label tweak does not work even after disabling the 'Conversations' add on

I think discussing proven facts (see comment https://github.com/Betterbird/thunderbird-patches/issues/277#issuecomment-1988050847) doesn't get us anywhere.

You're correct that the suggestion for .detailsLine doesn't work for Conversations, although the add-on defines this: image

For some reason the CSS in userChrome.css doesn't take effect.

Alfred-Peters commented 4 months ago

I hope I can clear this up: You're both absolutely right. 😉

Whether the foo rule works depends on the option: Headerpane -> [More] -> Customize... -> [ ] Hide labels column

If it is switched on, there is no .message-header-label - but then there is a .row-heading. Therefore, this one should work:

.message-header-label, .row-heading {
  color: red ! important;
  font-weight: bold ! important;
}
Betterbird commented 4 months ago

Thanks, Alfred. Well, if there is no label, then there's nothing to colour. Any idea why the CSS for "Conversations" doesn't take effect?

Alfred-Peters commented 4 months ago

You mean the AddOn? Yes, that's a nasty trick. The Conversation headerpane is not the right headerpane. The AddOn completely recreates it. And it does so in the body! And this means that the detailsLine rule must be included in userContent.css.

Betterbird commented 4 months ago

Ouch!!

PaduaPlay commented 4 months ago

Thanks for the clarifications, @Alfred-Peters . They work. The usercontent.css tweak suggested to make this work with the 'Conversations' addon works as well. Glad that this works, since it is a useful addon.

A WYSIWIG UI customization or css generating tool would be a, very nice to have, companion app, and, so too would be a forum, for BetterBird, in English.

Betterbird commented 4 months ago

Well, there is https://www.reddit.com/r/Betterbird/.