Betterbird / thunderbird-patches

Betterbird is a fork of Mozilla Thunderbird. Here are the patches that provide all the goodness.
Other
424 stars 18 forks source link

Stop annoying pop-ups that lose keyboard focus #280

Closed ferrieux closed 4 months ago

ferrieux commented 4 months ago

Hello,

Since version 115, many background tasks that formerly were only mentioned in the status line, now post a pop-up window saying something of groundbreaking importance like "Fetching e-mail" or "Retrieving certificates".

This is really annoying, as the result is losing keyboard focus. You end up losing several sentences of text in the currently composed message.

Could someone roll back this "innovation" ? Or is there some config variable to disable it ?

Thanks in advance,

-Alex

Betterbird commented 4 months ago

We're not aware of pop-up windows with "Fetching e-mail" or "Retrieving certificates". Can you please attach a screenshot.

ferrieux commented 4 months ago

The text is approximative, and the presence of the pop-up is fleeting (but enough to lose the focus). I cannot seem to reproduce right now, presumably this is linked to some network delay or packet loss on the IMAP or LDAP paths. I will arrange for a screencast then extract the specific frames showing the pop-ups, when I am able to reproduce.

One thing though: if you abstract away the exact contents of these pop-ups, do you have in mind a situation where the code could decide to show them based on some timing issue ? In other software, it is not uncommon to see a "stuck eventloop watchdog", that would kick in if the main thread has not polled for events for X milliseconds or so.

ferrieux commented 4 months ago

Update: I have a repro now :)

I've done a screencast and extracted the frame:

popup

This window pops up roughly 5 seconds after a "Reply To All" on a message with 4 recipients. Interestingly, I have disabled encryption and signature by default.

For some reason, while the pop-up disappeared spontaneously after 1 second, the situation is "sticky" in that the certificates never end up being downloaded (possibly due to an LDAP misconfiguration here, but that's another story).

Betterbird commented 4 months ago

Yes, this is an LDAP dialogue, I've seen it on profiles where LDAP is configured. I'm not aware it steals the focus.

ferrieux commented 4 months ago

Well, stealing the focus may depend on the window manager and its configuration (focus-follow-mouse, click-to-focus, etc). However, changing this just because of an unwanted behavior of an isolated application, be it the e-mail client, is not an option. So, Betterbird should not make any assumption on the focus policy, and just refrain from posting pop-ups.

Note: I am aware of the temptation to use pop-ups with a Cancel button, when the associated asynchronous task may be cancelled. However, there are other options: (1) a dedicated menu entry or submenu in the top menubar; (2) forget about cancelling, just like for "Compact folders" which is not cancellable.

Betterbird commented 4 months ago

Please report your concerns in an upstream ticket at https://bugzilla.mozilla.org/.

ferrieux commented 4 months ago

Okay, done: https://bugzilla.mozilla.org/show_bug.cgi?id=1885731

Betterbird commented 4 months ago

Actually, the same pop-up appears in 102.

ferrieux commented 4 months ago

Possibly, I typically don't upgrade unless pushed by bugfixes :)

On a side note: kudos for the principle of Betterbird. Focusing on stability instead of featurism is really refreshing in this day and age.

Betterbird commented 4 months ago

We have a few features :wink: - https://www.betterbird.eu/#featuretable