search

Betterbird / thunderbird-patches

Betterbird is a fork of Mozilla Thunderbird. Here are the patches that provide all the goodness.
Other
424 stars 18 forks source link

build error for Betterbird 128 #287

Closed artix-arist closed 3 months ago

artix-arist commented 3 months ago

Maybe it's too early to build Betterbird v128 from source but this is the error that occurs then:

4:57.28 /build/betterbird/src/mozilla-central/comm/mailnews/compose/src/nsMsgCompose.cpp:248:21: error: non-const lvalue reference to type 'nsAString' (aka 'nsTSubstring') cannot bind to a value of unrelated type 'nsAutoCString' (aka 'nsTAutoStringN<char, AutoStringDefaultStorageSize>') 4:57.28 248 | anchor->GetHref(objURL);

Maybe this is related to 12+13-feature-linux-systray-incl-minimise.patch ?

Thx for looking into this.

Betterbird commented 3 months ago

Too early, we haven't compiled it yet, we're still adjusting patches for 128, well, currently at 126.

Looks like a simple compile error, looks like something like this is needed: https://hg.mozilla.org/comm-central/rev/a25bf321fdd3e4e8179fba4d147716b36f599099#l1.12

Betterbird commented 3 months ago

We've built it now on Windows with ./build.sh 128. This is of course a build based on TB 126. On Windows it starts, but there are various issues we need to address (like no mail displayed).

It's possible that it doesn't compile on Linux. We have a contributor who will build on Linux "soon" and we'll let you know when it's ready.