Betterbird / thunderbird-patches

Betterbird is a fork of Mozilla Thunderbird. Here are the patches that provide all the goodness.
Other
424 stars 18 forks source link

The bottom part of the 'About Betterbird' Window is cut off #315

Open kiki-ja opened 3 weeks ago

kiki-ja commented 3 weeks ago

The bottom of the 'About Betterbird' window is cut off and the text is not visible. Please see the screenshot. Is this a problem in my environment?

About Betterbird 102-115


I modified it by adding the following two lines to 'aboutDialog.css'.

#leftBox {
  background-image: url("chrome://branding/content/about-logo.svg");
  background-repeat: no-repeat;
  /* min-width and min-height create room for the logo */
  min-width: 210px;
  min-height: 210px;
 + margin-top: 20px; /* add */
 + margin-bottom: 20px; /* add */
  margin-inline-start: 30px;
}

Below is a screenshot of the results.

About Betterbird +20px

Betterbird について +20px

@kiki-ja

Betterbird commented 3 weeks ago

Hmm, works for me:

Windows: image

Linux: image

Why doesn't it fit for you? Looks like the logo is too small. I can add the margin, it was requested here: Issue #241

Betterbird commented 3 weeks ago

Does it work with 10px margin instead of 20px? How about increasing min-height?

kiki-ja commented 3 weeks ago

I saw your screenshot and it turns out that it seems to be a problem with my system font.

Why doesn't it fit for you? Looks like the logo is too small.

On my Windows 10 PC I have changed the system font and size so the font is probably a bit large for the logo. This is probably why the logo appears small in terms of balance. This may be the reason why the bottom row of text is two lines long and cut off from the window.

My system font: 'BIZ UDGothic font family' https://learn.microsoft.com/en-us/typography/font-list/biz-udgothic

I can add the margin, it was requested here: Issue #241

Seems like a problem with my font. But it is strange because in Thunderbird it is not a problem.(?????) If it is not a problem in other users' environments, then there is no need to add margins.

Does it work with 10px margin instead of 20px?

10px margin would work, but a 20px margin was best.

margin 10px case: About Betterbird +10px Betterbird について +10px

How about increasing min-height?

I tried it, but up the min-height did not make the desired change.


So I will deal with this by customizing it with CSS.

userChrome.css:

#leftBox {
  margin-top: 20px !important;
  margin-bottom: 20px !important;
}

Thank you very much.

@kiki-ja

Betterbird commented 3 weeks ago

Thanks for the details, we'll consider adding 15px margin since something similar was requested in Issue #241.