search

Betterbird / thunderbird-patches

Betterbird is a fork of Mozilla Thunderbird. Here are the patches that provide all the goodness.
Other
516 stars 20 forks source link

Light theme Calendar has events time and description white text on white background, can see only by clicking them #361

Closed xet7 closed 4 weeks ago

xet7 commented 4 weeks ago

Hi, Light theme Calendar has events time and description white text on white background, can see only by clicking them.

Dark theme has correct colors, but it's hard for my eyes to use dark theme. I would like to use Light theme.

Betterbird commented 4 weeks ago

This report is missing information. Which version are you using, which OS are you using and which theme are you using, if any?

What is "Light theme Calendar"?

BB (and TB) do not show time and description as white on white, if it were so, you'd have an uproar. Here's a screenshot of the Windows light theme: image

Can you supply a screenshot?

xet7 commented 4 weeks ago

It seems that I found a way to fix it.

Similar that in your screenshot is "Holidays in Germany", I had CalDAV remote calendar. I had to:

  1. Right click that calendar name
  2. Change color, to be new background color
  3. After that, calendar events are visible.

This is on Linux Mint 22 Wilma amd64.

xet7 commented 4 weeks ago

Here is screenshot of that bug. Where mouse pointer is, there is some event, that is not visible.

This happens after adding remote CalDAV calendar.

So it requires changing calendar color.

light

xet7 commented 4 weeks ago

Does this happen to anyone else, that adds remote CalDAV calendar?

Remote CalDAV server is Radicale app at https://sandstorm.org server.

xet7 commented 4 weeks ago

This is the theme I'm using at Betterbird.

light-theme

Betterbird commented 4 weeks ago

Even for a calendar colour of white, it's black on white, at least on Windows: image

Surely TB is the same and it would be an upstream bug.

Betterbird commented 3 weeks ago

So what was the solution in the end? We did a few checks and never saw white on white.

xet7 commented 3 weeks ago

This solution above https://github.com/Betterbird/thunderbird-patches/issues/361#issuecomment-2448280508

Betterbird commented 3 weeks ago

The point is that the software has a contrast calculation, if black (foreground) writing on the chosen background doesn't have enough contrast, then the (foreground) writing is switched to white. Tested on Linux (Mint 20 with Xfce) with the screenshot below: image

So a case white on white should not happen, unless your system for some reason changes black on white to white on white.