Betterment / alchemist

A Flutter tool that makes golden testing easy.
MIT License
251 stars 35 forks source link

fix: loading fonts from other packages #111

Closed krispypen closed 1 week ago

krispypen commented 6 months ago

Description

Font rendering did not work when fonts are from another package. We are using a separate package for our styleguide including assets, textstyles and fonts... This change makes it possible.

Type of Change

bmt-github-policybot commented 5 months ago

This pull request has been automatically closed because it has not been updated in the last month. :sleepy:

If you still need this change, you can reopen it.

Thanks for helping keep our house in order!

TimmyChannel commented 1 month ago

Thank you!

btrautmann commented 1 month ago

@krispypen mind pushing an empty commit to your branch? We updated CI configuration on our end which seems to have reset the statuses for build and pana and AFAIK Github UI has no way of kicking these off separately/manually. I'll re-approve upon success and we can get this merged.

krispypen commented 1 month ago

hey @btrautmann I pushed an empty commit, not sure if it's actually triggering something now

btrautmann commented 1 month ago

hey @btrautmann I pushed an empty commit, not sure if it's actually triggering something now

Looks like it worked, we just have one failing test

pedromassango commented 1 week ago

Hi everyone, can we get this in, pls?

btrautmann commented 1 week ago

Hi everyone, can we get this in, pls?

@krispypen just needs to patch/address the one failing test

krispypen commented 1 week ago

oh, having a look sorry ๐Ÿฅน

krispypen commented 1 week ago

I did the change and locally it works, but it looks like someone needs to approve before the test runs.