Betterment / alchemist

A Flutter tool that makes golden testing easy.
MIT License
268 stars 36 forks source link

fix: Bump very_good_analysis & prepare for latest flutter version #129

Closed pedromassango closed 2 months ago

pedromassango commented 2 months ago

Description

Migrate deprecated members & bump very_good_analysis

Type of Change

btrautmann commented 2 months ago

@pedromassango probably the highest version we could adopt while keeping dart/Flutter constraints the same (which is desirable) is 5.1.0 based on the changelog.

pedromassango commented 2 months ago

@pedromassango probably the highest version we could adopt while keeping dart/Flutter constraints the same (which is desirable) is 5.1.0 based on the changelog.

It that case, how to we use the package while using the most common lint rules?

I get this in a private project, and can't ignore it across all files or disable this lint

Screenshot 2024-09-24 at 22 43 33
btrautmann commented 2 months ago

It that case, how to we use the package while using the most common lint rules?

That lint is unrelated to alchemist, no? It's just stating that you're calling goldenTest (an async function) in a non-async function (main). You can add the async modifier to main if you want and await goldenTest if you want this lint to be satisfied.

pedromassango commented 2 months ago

will close this for now

jeroen-meijer commented 2 months ago

Quick tip that you probably don't want to await a goldenTest call, right?

pedromassango commented 2 months ago

Quick tip that you probably don't want to await a goldenTest call, right?

Yes