search

Betterment / betterlint

MIT License
41 stars 15 forks source link

feat(rubocop-rspec): disable FactoryBot SyntaxMethods rule #13

Closed HipsterBrown closed 1 year ago

HipsterBrown commented 1 year ago

Based on feedback from an automated linter fix from rubocop-rspec v2.7 (https://github.com/Betterment/test_track/pull/182#discussion_r1117806216), creating this PR to start a conversation around disabling the rule for apps that depend on this gem going forward.

Docs for the rule being disabled

/cc: @smudge

HipsterBrown commented 1 year ago

Not sure why these rules are failing now, given the simple changeset.

smudge commented 1 year ago

@HipsterBrown These are probably new linter rules that got introduced since our last build -- we enable new rules by default now.

HipsterBrown commented 1 year ago

@smudge Can you merge this? I don't have the permissions for this repo. Thank you!

smudge commented 1 year ago

Merging and releasing!