This is a mistake I've made at least twice now. Basically, query params like ?should_do_something=false will result in the value of string 'false' when fetched from a params object.
The only way that they can be falsey is if they are omitted from the request and default to false. This is also an issue where we are expecting exactly true and not just any truthy value. The solution is to cast them explicitly
# Always an actual boolean value
should_do_something = ActiveModel::Type::Boolean.new.cast(params.fetch(:should_do_something, false))
This is a mistake I've made at least twice now. Basically, query params like
?should_do_something=falsewill result in the value of string 'false' when fetched from a params object.The only way that they can be falsey is if they are omitted from the request and default to false. This is also an issue where we are expecting exactly true and not just any truthy value. The solution is to cast them explicitly