search

Betterment / delayed

a multi-threaded, SQL-driven ActiveJob backend used at Betterment to process millions of background jobs per day
MIT License
156 stars 9 forks source link

Create a JobRecord abstract parent class for Delayed::Job #12

Closed fractaledmind closed 2 years ago

fractaledmind commented 2 years ago

This is a simple refactor that opens the doors to an experiment that I was running to used Delayed with a separate SQLite database. In order to get this to work tho, I needed an abstract class extension point to call connects_to on (https://api.rubyonrails.org/classes/ActiveRecord/ConnectionHandling.html#method-i-connects_to).

I am going to open up a separate issue to discuss that experiment in more detail, but I'm hoping this minor tweak to the structure can be added now to provide such possibilities.

nanda-prbot commented 2 years ago

@fractaledmind needs to request domain review. @fractaledmind isn't a platform reviewer and needs to request platform review.

HOW TO: Request Reviewers

bmt-github-policybot commented 2 years ago

This pull request has been automatically closed because it has not been updated in the last 3 months. :sleepy:

If you still need this change, please reopen it and update it within the next 3 months.

Thanks for helping keep our house in order!