This PR removes the after_create callback from DemoMode::Session. This will allow the CLI to generate DemoMode::Session records while still performing account generation inline.
This PR also includes a unrelated improvements:
Makes DemoMode::Session#persona public and removes duplication in AccountGenerationJob.
gemfiles/*.gemfile are generated automatically, so we shouldn't be running Rubocop against them.
This gem doesn't depend on SemanticLogger and therefore shouldn't refer to it.
Many of our tests rely on DemoMode being configured. In some of those specs, we forgot to reset the configuration. In order to mitigate this potential footgun, I moved the code that resets the configuration to a global hook in spec_helper.rb.
This PR removes the
after_createcallback fromDemoMode::Session. This will allow the CLI to generateDemoMode::Sessionrecords while still performing account generation inline.This PR also includes a unrelated improvements:
DemoMode::Session#personapublic and removes duplication inAccountGenerationJob.gemfiles/*.gemfileare generated automatically, so we shouldn't be running Rubocop against them.SemanticLoggerand therefore shouldn't refer to it.DemoModebeing configured. In some of those specs, we forgot to reset the configuration. In order to mitigate this potential footgun, I moved the code that resets the configuration to a global hook inspec_helper.rb.