Betterment / demo_mode

A configurable demo mode for your Rails app. Specify your desired "personas" and Demo Mode will handle the rest.
MIT License
25 stars 8 forks source link

Fix migration generator - rubygems release did not include migrations! #6

Closed smudge closed 2 years ago

smudge commented 2 years ago

/domain @Betterment/demo_mode-core /no-platform

Update: This is the actual fix. While #5 blocked the engine's ability to actually load inside of the generator, I still wasn't seeing the migrations applied by the new 1.0.2 -- it turns out it's because they weren't actually being shipped to rubygems.org! 🤦

nanda-prbot commented 2 years ago

Needs somebody from @jmileham, @JELaVallee, and @agirlnamedsophia to claim domain review

Use the shovel operator to claim, e.g.:

@myname << domain && platform

HOW TO: Claim a Review

nanda-prbot commented 2 years ago

Needs somebody from @jmileham, @JELaVallee, and @agirlnamedsophia to claim domain review

Use the shovel operator to claim, e.g.:

@myname << domain && platform

HOW TO: Claim a Review

nanda-prbot commented 2 years ago

Needs somebody from @Betterment/demo_mode-core to claim domain review

Use the shovel operator to claim, e.g.:

@myname << domain && platform

HOW TO: Claim a Review

nanda-prbot commented 2 years ago

Needs somebody from @Betterment/demo_mode-core to claim domain review

Use the shovel operator to claim, e.g.:

@myname << domain && platform

HOW TO: Claim a Review

nanda-prbot commented 2 years ago

Needs somebody from @Betterment/demo_mode-core to claim domain review

Use the shovel operator to claim, e.g.:

@myname << domain && platform

HOW TO: Claim a Review

jmileham commented 2 years ago

<< domain lgtm!

pat-whitrock commented 2 years ago

<< domain LGTM

Seems fine to include the entire db directory since there should never be a schema.rb included in there. Was gonna suggest potentially just including db/migrate, but seems fine either way.

nanda-prbot commented 2 years ago

Approved! :fireworks: :100: :sparkles: