Closed smudge closed 2 years ago
Needs somebody from @jmileham, @JELaVallee, and @agirlnamedsophia to claim domain review
Use the shovel operator to claim, e.g.:
@myname << domain && platform
Needs somebody from @jmileham, @JELaVallee, and @agirlnamedsophia to claim domain review
Use the shovel operator to claim, e.g.:
@myname << domain && platform
Needs somebody from @Betterment/demo_mode-core to claim domain review
Use the shovel operator to claim, e.g.:
@myname << domain && platform
Needs somebody from @Betterment/demo_mode-core to claim domain review
Use the shovel operator to claim, e.g.:
@myname << domain && platform
Needs somebody from @Betterment/demo_mode-core to claim domain review
Use the shovel operator to claim, e.g.:
@myname << domain && platform
<< domain lgtm!
<< domain LGTM
Seems fine to include the entire db
directory since there should never be a schema.rb
included in there. Was gonna suggest potentially just including db/migrate
, but seems fine either way.
Approved! :fireworks: :100: :sparkles:
/domain @Betterment/demo_mode-core /no-platform
Update: This is the actual fix. While #5 blocked the engine's ability to actually load inside of the generator, I still wasn't seeing the migrations applied by the new 1.0.2 -- it turns out it's because they weren't actually being shipped to rubygems.org! 🤦