search

Betterment / journaled

A Rails engine to reliably deliver loosely-ordered schematized events to Amazon Kinesis via Delayed::Job
MIT License
13 stars 9 forks source link

Update CI files to use latest docker images #1

Closed jacoblipson closed 5 years ago

jacoblipson commented 5 years ago

Summary

Update Circle CI config files to support updated docker images in test builds

/domain @kelvin-acosta @Betterment/journaled-owners /platform @kelvin-acosta @jmileham @coreyja @ceslami @danf1024

nanda-prbot commented 5 years ago

Needs somebody from @kelvin-acosta and @Betterment/journaled-owners to claim domain review Needs somebody from @jmileham, @coreyja, @ceslami, and @danf1024 to claim platform review

Use the shovel operator to claim, e.g.:

@myname << domain && platform

(Ignored request for platform review from kelvin-acosta. See here for our list of platform experts.)

jmileham commented 5 years ago

though I don't know what needs doing (if anything) to get circle to run on this PR

kelvin-acosta commented 5 years ago

ah, this repo wasn't enabled in circleci

kelvin-acosta commented 5 years ago

I think this is going to take one more commit to trigger in circleci since it wasn't enabled in circle prior to the PR, could be anything

kelvin-acosta commented 5 years ago

Going to push a small commit to trigger circle

kelvin-acosta commented 5 years ago

<< domain lgtm

nanda-prbot commented 5 years ago

Needs somebody from @jmileham, @coreyja, @ceslami, and @danf1024 to claim platform review

Use the shovel operator to claim, e.g.:

@myname << domain && platform

(Ignored request for platform review from kelvin-acosta. See here for our list of platform experts.)

jmileham commented 5 years ago

<< platform lgtm

nanda-prbot commented 5 years ago

Approved! :balloon: :squirrel: :metal: