Betterment / journaled

A Rails engine to reliably deliver loosely-ordered schematized events to Amazon Kinesis via Delayed::Job
MIT License
13 stars 9 forks source link

Add Rails 7.1 testing #35

Closed argvniyx-enroute closed 6 months ago

argvniyx-enroute commented 7 months ago

Summary

I stumbled upon an error when trying to add Rails 7.1 support to a journaled dependent: in audit_log.rb, we call skip_audit_log on certain ActiveRecord classes which no longer inherit from ActiveRecord::Base in 7.1, so that would raise with a NoMethodError. This PR:

Other Information

There might be some other things worth considering (not ignoring lockfiles(?), actually using the new connection handling (even if it is only a dummy app)) but I didn't want to drag out a PR that's already pretty big.

Thanks for contributing to Journaled!

/domain @smudge @Betterment/journaled-owners /platform @smudge

lindan-betterment commented 6 months ago

@argvniyx-enroute @smudge: Unblocked! - disabled Semgrep for this repo.