Betterment / journaled

A Rails engine to reliably deliver loosely-ordered schematized events to Amazon Kinesis via Delayed::Job
MIT License
13 stars 9 forks source link

`insert_all!` missing from list of blocked bulk operations for audit logging #36

Open medlefsen opened 4 months ago

medlefsen commented 4 months ago

Ran into a case where we were calling insert_all! on a model without disabling audit logging. Looks like we don't have this method on the list. We do have insert_all without the ! and the only difference between them how they handle conflicts, so I think we would want both.

https://github.com/Betterment/journaled/blob/master/lib/journaled/audit_log.rb#L181-L188