search

Betterment / test_track

Server app for the TestTrack multi-platform split-testing and feature-gating system
MIT License
119 stars 33 forks source link

Feature completion migration endpoint #108

Closed jmileham closed 5 years ago

jmileham commented 5 years ago

Summary

This adds a new migration endpoint to create/update/destroy feature completions. I renamed a the AppFeatureCompletion.split_id column to feature_gate_id in the process and validated that it's the right kind of split now that I'm shoring this up for data integrity while receiving untrusted input.

I'll drop a comment with the version range that's real because this includes remote_kill's commits right now.

/domain @Betterment/test_track_core /platform @samandmoore @smudge

nanda-prbot commented 5 years ago

Needs somebody from @Betterment/test_track_core to claim domain review Needs somebody from @samandmoore and @smudge to claim platform review

Use the shovel operator to claim, e.g.:

@myname << domain && platform

jmileham commented 5 years ago

@smudge << domain platform

Remember the diff that's actually distinct here is just: https://github.com/Betterment/test_track/pull/108/files/6bf010c96827fefdacfcb30e7396659c312d2352..fab1a02bc5d6ffcac5e60d5cf65b82a3c4af77e0

nanda-prbot commented 5 years ago

Needs @smudge to provide platform review Needs @smudge to provide domain review

When you finish a round of review, be sure to say you've finished or sign off on the PR, e.g.:

TAFN or DomainLGTM

If you're too busy to review, unclaim the PR, e.g.:

@myname >> domain

smudge commented 5 years ago

domain LGTM && platform LGTM 👍

nanda-prbot commented 5 years ago

Approved! :star: :golf: :dart: