Closed jmileham closed 5 years ago
@jmileham needs to request platform review, or explicitly opt out, e.g.:
/no-platform
/platform @coreyja
Needs somebody from @Betterment/test_track_core to claim domain review Needs somebody from @coreyja to claim platform review
Use the shovel operator to claim, e.g.:
@myname << domain && platform
<< platform LGTM
<< domain TAFN
Code looks great! Left one small idea about adding the variant we decided too
@jmileham needs to incorporate feedback from @coreyja. Bump when done.
Good call. Screenies below
Decided:
Finished:
bump
Needs @coreyja to provide domain review
When you finish a round of review, be sure to say you've finished or sign off on the PR, e.g.:
TAFN
orDomainLGTM
If you're too busy to review, unclaim the PR, e.g.:
@myname >> domain
bumpalump
<< domain LGTM
Approved! :heart_eyes_cat: :zap: :raised_hands:
Summary
fixes #122
Other Information
There are no tests on this field, and I didn't add any, but the Active codepath actually covers the finished and decided conditionals via fallthru, so this would be hard to break unless the definitions of finished or decided changed.
/domain @Betterment/test_track_core