Show decided state in admin

Betterment / test_track

Server app for the TestTrack multi-platform split-testing and feature-gating system

MIT License

119 stars 33 forks source link

Show decided state in admin #124

Closed jmileham closed 5 years ago

jmileham commented 5 years ago

Summary

fixes #122

Other Information

There are no tests on this field, and I didn't add any, but the Active codepath actually covers the finished and decided conditionals via fallthru, so this would be hard to break unless the definitions of finished or decided changed.

/domain @Betterment/test_track_core

nanda-prbot commented 5 years ago

@jmileham needs to request platform review, or explicitly opt out, e.g.:

/no-platform

jmileham commented 5 years ago

/platform @coreyja

nanda-prbot commented 5 years ago

Needs somebody from @Betterment/test_track_core to claim domain review Needs somebody from @coreyja to claim platform review

Use the shovel operator to claim, e.g.:

@myname << domain && platform

coreyja commented 5 years ago

<< platform LGTM

<< domain TAFN

Code looks great! Left one small idea about adding the variant we decided too

nanda-prbot commented 5 years ago

@jmileham needs to incorporate feedback from @coreyja. Bump when done.

jmileham commented 5 years ago

Good call. Screenies below

Decided:

Finished:

jmileham commented 5 years ago

bump

nanda-prbot commented 5 years ago

Needs @coreyja to provide domain review

When you finish a round of review, be sure to say you've finished or sign off on the PR, e.g.:

TAFN or DomainLGTM

If you're too busy to review, unclaim the PR, e.g.:

@myname >> domain

jmileham commented 5 years ago

bumpalump

coreyja commented 5 years ago

<< domain LGTM

nanda-prbot commented 5 years ago

Approved! :heart_eyes_cat: :zap: :raised_hands: