Closed joejansen closed 5 years ago
Needs somebody from @Betterment/test_track_core to claim domain review Needs somebody from @jmileham to claim platform review
Use the shovel operator to claim, e.g.:
@myname << domain && platform
<< domain
Needs somebody from @jmileham and @aburgel to claim platform review
Use the shovel operator to claim, e.g.:
@myname << domain && platform
<< platform - Burgel's gonna take this over while @joejansen's out
Needs @aburgel to provide domain review Needs @jmileham to provide platform review
When you finish a round of review, be sure to say you've finished or sign off on the PR, e.g.:
TAFN
orDomainLGTM
If you're too busy to review, unclaim the PR, e.g.:
@myname >> domain
@aburgel >> domain << domain
cuz why not
tafn
Needs @jmileham to provide platform review Needs @jmileham to provide domain review
When you finish a round of review, be sure to say you've finished or sign off on the PR, e.g.:
TAFN
orDomainLGTM
If you're too busy to review, unclaim the PR, e.g.:
@myname >> domain
nanda
@joejansen needs to incorporate feedback from @jmileham. Bump when done.
Reopened with some modification in #126 since this PR off a fork.
Summary
https://github.com/Betterment/test_track/pull/123 introduced a change that results in the
mixpanel_result
never being updated when the client sends a request toDeterministicAssignmentCreation
for an existing assignment. I believe the sequence of events would look something like this:Api::V1::AssignmentEventsController
with params that have anil
mixpanel_result
.Api::V1::AssignmentEventsController
with params that have a"success"
mixpanel_result
.DeterministicAssignmentCreation
doesn't callArbitraryAssignmentCreation
because it finds anexisting_assignment
."unsynced": true
.Api::V1::AssignmentEventsController
with params that have a"success"
mixpanel_result
.DeterministicAssignmentCreation
doesn't callArbitraryAssignmentCreation
because it finds anexisting_assignment
.4 to 6 keep repeating for each page load.
This changes proposes a
should_create_or_update_assignment?
expression that incorporates a comparison of whether the existing and newmixpanel_result
s are equal.It also adds an optional
created_at
attr toArbitraryAssignmentCreation
so we can choose to preserve the existing assignment timestamp if we don't want the defaultnow
./domain @Betterment/test_track_core /platform @jmileham @aburgel