Closed aburgel closed 5 years ago
Needs somebody from @jmileham to claim domain review Needs somebody from @jmileham to claim platform review
Use the shovel operator to claim, e.g.:
@myname << domain && platform
<< domain platform
Needs @jmileham to provide platform review Needs @jmileham to provide domain review
When you finish a round of review, be sure to say you've finished or sign off on the PR, e.g.:
TAFN
orDomainLGTM
If you're too busy to review, unclaim the PR, e.g.:
@myname >> domain
should we add a ratchet so you can't change the mixpanel result after it's already in a terminal state? That's an optional feature add so domain lgtm platform lgtm!
Approved! :fireworks: :dart: :clap:
should we add a ratchet so you can't change the mixpanel result after it's already in a terminal state
i like this idea. i'm now only allowing mixpanel_result
to change if its not 'success'
NOTE: This is built upon #125. I had to open a new PR since that PR was off of a fork. I made the following modification: Consolidated the logic in
DeterministicAssignmentCreation
to reduce coupling toArbitraryAssignmentCreation
and to close the window in which a new variant could be unintentially assigned.Summary
https://github.com/Betterment/test_track/pull/123 introduced a change that results in the
mixpanel_result
never being updated when the client sends a request toDeterministicAssignmentCreation
for an existing assignment. I believe the sequence of events would look something like this:Api::V1::AssignmentEventsController
with params that have anil
mixpanel_result
.Api::V1::AssignmentEventsController
with params that have a"success"
mixpanel_result
.DeterministicAssignmentCreation
doesn't callArbitraryAssignmentCreation
because it finds anexisting_assignment
."unsynced": true
.Api::V1::AssignmentEventsController
with params that have a"success"
mixpanel_result
.DeterministicAssignmentCreation
doesn't callArbitraryAssignmentCreation
because it finds anexisting_assignment
.4 to 6 keep repeating for each page load.
This changes proposes ashould_create_or_update_assignment?
expression that incorporates a comparison of whether the existing and newmixpanel_result
s are equal.It also adds an optionalcreated_at
attr toArbitraryAssignmentCreation
so we can choose to preserve the existing assignment timestamp if we don't want the defaultnow
./domain @jmileham /platform @jmileham /cc @joejansen