Closed phantomphildius closed 4 years ago
@phantomphildius isn't a platform reviewer and needs to request platform review.
/platform @aburgel @jmileham @smudge @samandmoore
Needs somebody from @Betterment/test_track_core to claim domain review Needs somebody from @aburgel, @jmileham, @smudge, and @samandmoore to claim platform review
Use the shovel operator to claim, e.g.:
@myname << domain && platform
nanda
Needs somebody from @Betterment/test_track_core to claim domain review Needs somebody from @aburgel, @jmileham, @smudge, and @samandmoore to claim platform review
Use the shovel operator to claim, e.g.:
@myname << domain && platform
that works for me!
nanda
Needs somebody from @Betterment/test_track_core to claim domain review Needs somebody from @aburgel, @jmileham, @smudge, and @samandmoore to claim platform review
Use the shovel operator to claim, e.g.:
@myname << domain && platform
nanda
Needs somebody from @Betterment/test_track_core to claim domain review Needs somebody from @aburgel, @jmileham, @smudge, and @samandmoore to claim platform review
Use the shovel operator to claim, e.g.:
@myname << domain && platform
<< domain LGTM - moving this to the v3
namespace came together really well!
Needs somebody from @aburgel, @jmileham, @smudge, and @samandmoore to claim platform review
Use the shovel operator to claim, e.g.:
@myname << domain && platform
nanda bump
Needs somebody from @aburgel, @jmileham, @smudge, and @samandmoore to claim platform review
Use the shovel operator to claim, e.g.:
@myname << domain && platform
<< platform tafn
@phantomphildius needs to incorporate feedback from @aburgel. Bump when done.
bump
Needs @aburgel to provide platform review
When you finish a round of review, be sure to say you've finished or sign off on the PR, e.g.:
TAFN
orDomainLGTM
If you're too busy to review, unclaim the PR, e.g.:
@myname >> domain
platformlgtm! awesome work, thanks for getting it over the finish line. left a couple of minor comments, then it's good to land.
Approved! :moneybag: :ok_hand: :+1:
Summary
Deprecates the current split registry endpoint (by renaming to v2/legacy_split_registry) and replaces with a new v2/split_registries that accepts a timestamp as a parameter. This will allow for finding the active splits as of that timestamp - rather than as of the current time.
/domain @Betterment/test_track_core