Betterment / test_track

Server app for the TestTrack multi-platform split-testing and feature-gating system
MIT License
119 stars 33 forks source link

Introduce Split Registry Endpoint Accepting a Timestamp #133

Closed phantomphildius closed 4 years ago

phantomphildius commented 4 years ago

Summary

Deprecates the current split registry endpoint (by renaming to v2/legacy_split_registry) and replaces with a new v2/split_registries that accepts a timestamp as a parameter. This will allow for finding the active splits as of that timestamp - rather than as of the current time.

/domain @Betterment/test_track_core

nanda-prbot commented 4 years ago

@phantomphildius isn't a platform reviewer and needs to request platform review.

phantomphildius commented 4 years ago

/platform @aburgel @jmileham @smudge @samandmoore

nanda-prbot commented 4 years ago

Needs somebody from @Betterment/test_track_core to claim domain review Needs somebody from @aburgel, @jmileham, @smudge, and @samandmoore to claim platform review

Use the shovel operator to claim, e.g.:

@myname << domain && platform

phantomphildius commented 4 years ago

nanda

nanda-prbot commented 4 years ago

Needs somebody from @Betterment/test_track_core to claim domain review Needs somebody from @aburgel, @jmileham, @smudge, and @samandmoore to claim platform review

Use the shovel operator to claim, e.g.:

@myname << domain && platform

phantomphildius commented 4 years ago

that works for me!

phantomphildius commented 4 years ago

nanda

nanda-prbot commented 4 years ago

Needs somebody from @Betterment/test_track_core to claim domain review Needs somebody from @aburgel, @jmileham, @smudge, and @samandmoore to claim platform review

Use the shovel operator to claim, e.g.:

@myname << domain && platform

phantomphildius commented 4 years ago

nanda

nanda-prbot commented 4 years ago

Needs somebody from @Betterment/test_track_core to claim domain review Needs somebody from @aburgel, @jmileham, @smudge, and @samandmoore to claim platform review

Use the shovel operator to claim, e.g.:

@myname << domain && platform

smudge commented 4 years ago

<< domain LGTM - moving this to the v3 namespace came together really well!

nanda-prbot commented 4 years ago

Needs somebody from @aburgel, @jmileham, @smudge, and @samandmoore to claim platform review

Use the shovel operator to claim, e.g.:

@myname << domain && platform

phantomphildius commented 4 years ago

nanda bump

nanda-prbot commented 4 years ago

Needs somebody from @aburgel, @jmileham, @smudge, and @samandmoore to claim platform review

Use the shovel operator to claim, e.g.:

@myname << domain && platform

aburgel commented 4 years ago

<< platform tafn

nanda-prbot commented 4 years ago

@phantomphildius needs to incorporate feedback from @aburgel. Bump when done.

phantomphildius commented 4 years ago

bump

nanda-prbot commented 4 years ago

Needs @aburgel to provide platform review

When you finish a round of review, be sure to say you've finished or sign off on the PR, e.g.:

TAFN or DomainLGTM

If you're too busy to review, unclaim the PR, e.g.:

@myname >> domain

aburgel commented 4 years ago

platformlgtm! awesome work, thanks for getting it over the finish line. left a couple of minor comments, then it's good to land.

nanda-prbot commented 4 years ago

Approved! :moneybag: :ok_hand: :+1: